Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753236AbZLOGsG (ORCPT ); Tue, 15 Dec 2009 01:48:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751556AbZLOGsF (ORCPT ); Tue, 15 Dec 2009 01:48:05 -0500 Received: from mail-pw0-f42.google.com ([209.85.160.42]:44337 "EHLO mail-pw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbZLOGsC convert rfc822-to-8bit (ORCPT ); Tue, 15 Dec 2009 01:48:02 -0500 MIME-Version: 1.0 In-Reply-To: <20091214064545.GK5114@elf.ucw.cz> References: <20091208102842.GH12264@elf.ucw.cz> <20091208214658.GC4164@elf.ucw.cz> <4B1ECEEE.3000209@bluewatersys.com> <4B203575.6050407@bluewatersys.com> <20091210172458.GJ19454@elf.ucw.cz> <4B2150B7.3040207@bluewatersys.com> <20091211221015.GB24456@elf.ucw.cz> <20091214064545.GK5114@elf.ucw.cz> Date: Mon, 14 Dec 2009 22:48:01 -0800 Message-ID: Subject: Re: GPIO support for HTC Dream From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: Pavel Machek Cc: H Hartley Sweeten , Ryan Mallon , Daniel Walker , Iliyan Malchev , Brian Swetland , kernel list , linux-arm-kernel Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1001 Lines: 28 On Sun, Dec 13, 2009 at 10:45 PM, Pavel Machek wrote: >> > +int __init dream_init_gpio(void) >> > +{ >> > + ? ? ? ?int i; >> > + >> > + ? ? ? ?for (i = 0; i < ARRAY_SIZE(msm_gpio_banks); i++) >> > + ? ? ? ? ? ? ? ?gpiochip_add(&msm_gpio_banks[i].chip); >> > + >> > + ? return 0; >> > +} >> >> Your original patch was initially writing the shadow values to the registers. >> Do you still need to do that? > > It seems to boot this way :-). If writing the shadow values is not > needed, lets try getting away without it... I may boot this way, but unless you know that the bootloader initialized all the registers to the same value, some outputs will be in the wrong state until someone writes to a gpio in the same bank. -- Arve Hj?nnev?g -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/