Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933469AbZLOT1G (ORCPT ); Tue, 15 Dec 2009 14:27:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933456AbZLOT06 (ORCPT ); Tue, 15 Dec 2009 14:26:58 -0500 Received: from hera.kernel.org ([140.211.167.34]:50797 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933417AbZLOT04 (ORCPT ); Tue, 15 Dec 2009 14:26:56 -0500 Date: Tue, 15 Dec 2009 19:25:02 GMT From: tip-bot for Masami Hiramatsu Cc: acme@redhat.com, mingo@redhat.com, peterz@infradead.org, fweisbec@gmail.com, dle-develop@lists.sourceforge.net, rostedt@goodmis.org, jbaron@redhat.com, tglx@linutronix.de, mhiramat@redhat.com, systemtap@sources.redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com, paulus@samba.org, fche@redhat.com, jkenisto@us.ibm.com, hch@infradead.org, ananth@in.ibm.com, srikar@linux.vnet.ibm.com, mingo@elte.hu, prasad@linux.vnet.ibm.com Reply-To: mingo@redhat.com, acme@redhat.com, peterz@infradead.org, fweisbec@gmail.com, dle-develop@lists.sourceforge.net, rostedt@goodmis.org, jbaron@redhat.com, tglx@linutronix.de, mhiramat@redhat.com, systemtap@sources.redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com, paulus@samba.org, fche@redhat.com, jkenisto@us.ibm.com, hch@infradead.org, ananth@in.ibm.com, srikar@linux.vnet.ibm.com, prasad@linux.vnet.ibm.com, mingo@elte.hu In-Reply-To: <20091215153121.17436.34674.stgit@dhcp-100-2-132.bos.redhat.com> References: <20091215153121.17436.34674.stgit@dhcp-100-2-132.bos.redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf probe: Check the result of e_snprintf() Message-ID: Git-Commit-ID: 7e990a51264cb0c1400155ba72d56f5158ccf919 X-Mailer: tip-git-log-daemon MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2202 Lines: 56 Commit-ID: 7e990a51264cb0c1400155ba72d56f5158ccf919 Gitweb: http://git.kernel.org/tip/7e990a51264cb0c1400155ba72d56f5158ccf919 Author: Masami Hiramatsu AuthorDate: Tue, 15 Dec 2009 10:31:21 -0500 Committer: Ingo Molnar CommitDate: Tue, 15 Dec 2009 20:22:00 +0100 perf probe: Check the result of e_snprintf() Fix show_perf_probe_event() to check the result of e_snprintf(). Signed-off-by: Masami Hiramatsu Cc: Paul Mackerras Cc: Arnaldo Carvalho de Melo Cc: Steven Rostedt Cc: Jim Keniston Cc: Ananth N Mavinakayanahalli Cc: Christoph Hellwig Cc: Frank Ch. Eigler Cc: Jason Baron Cc: K.Prasad Cc: Peter Zijlstra Cc: Srikar Dronamraju Cc: systemtap Cc: DLE Cc: Frederic Weisbecker LKML-Reference: <20091215153121.17436.34674.stgit@dhcp-100-2-132.bos.redhat.com> Signed-off-by: Ingo Molnar --- tools/perf/util/probe-event.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index add379c..1653a62 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -385,10 +385,12 @@ static void clear_probe_point(struct probe_point *pp) static void show_perf_probe_event(const char *group, const char *event, const char *place, struct probe_point *pp) { - int i; + int i, ret; char buf[128]; - e_snprintf(buf, 128, "%s:%s", group, event); + ret = e_snprintf(buf, 128, "%s:%s", group, event); + if (ret < 0) + die("Failed to copy event: %s", strerror(-ret)); printf(" %-40s (on %s", buf, place); if (pp->nr_args > 0) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/