Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760809AbZLOVVf (ORCPT ); Tue, 15 Dec 2009 16:21:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755513AbZLOVVe (ORCPT ); Tue, 15 Dec 2009 16:21:34 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:50125 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755429AbZLOVVd (ORCPT ); Tue, 15 Dec 2009 16:21:33 -0500 Date: Tue, 15 Dec 2009 22:21:26 +0100 From: Pavel Machek To: Daniel Walker Cc: Arve Hj?nnev?g , H Hartley Sweeten , Ryan Mallon , Iliyan Malchev , Brian Swetland , kernel list , linux-arm-kernel Subject: Re: GPIO support for HTC Dream Message-ID: <20091215212125.GQ24406@elf.ucw.cz> References: <4B2150B7.3040207@bluewatersys.com> <20091211221015.GB24456@elf.ucw.cz> <20091214064545.GK5114@elf.ucw.cz> <1260813293.13078.15.camel@c-dwalke-linux.qualcomm.com> <20091215191229.GC26422@elf.ucw.cz> <1260907626.32296.16.camel@c-dwalke-linux.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1260907626.32296.16.camel@c-dwalke-linux.qualcomm.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 33 On Tue 2009-12-15 12:07:06, Daniel Walker wrote: > On Tue, 2009-12-15 at 20:12 +0100, Pavel Machek wrote: > > > > One other thing. Are the gpio's handled by Pavel's driver actually from the > > > > MSM chip or from an external CPLD? The registers are all defined as: > > > > > > > > + .reg = reg_num + DREAM_CPLD_BASE, > > > > > > > > If they are external from the MSM chip this driver should probably be renamed > > > > to something more appropriate since it is probably dream specific and not > > > > generic to the msm architecture. > > > > > > These are board specific gpios. I think it would be less confusing if > > > the msm gpio support was added first. > > > > I did not see msm-generic gpios in the trees, where are they? What is > > connected over them? > > Did you look at arch/arm/mach-msm/gpio.[ch] ? It looks like there some > idle related code in there, and "SMEM" is connected through that code. > (unless I'm looking at an older tree.) Aha, I see... more gpios. No wonder I had problems with MMC and framebuffer.... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/