Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754660AbZLOXlh (ORCPT ); Tue, 15 Dec 2009 18:41:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751927AbZLOXlf (ORCPT ); Tue, 15 Dec 2009 18:41:35 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:53939 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbZLOXle (ORCPT ); Tue, 15 Dec 2009 18:41:34 -0500 Date: Tue, 15 Dec 2009 15:41:14 -0800 From: Andrew Morton To: Alan Cox Cc: "H. Peter Anvin" , Thadeu Lima de Souza Cascardo , linux-kernel@vger.kernel.org, rubini@gnudd.com, gregkh@suse.de Subject: Re: [PATCH 3/3] misc: use a proper range for minor number dynamic allocation Message-Id: <20091215154114.e45e61d0.akpm@linux-foundation.org> In-Reply-To: <20091215233738.26188500@lxorguk.ukuu.org.uk> References: <1257813017-28598-1-git-send-email-cascardo@holoscopio.com> <1257813017-28598-2-git-send-email-cascardo@holoscopio.com> <1257813017-28598-3-git-send-email-cascardo@holoscopio.com> <4AF8B4FF.9050405@zytor.com> <20091111153632.944a255c.akpm@linux-foundation.org> <20091215143446.8b6a7e57.akpm@linux-foundation.org> <20091215233738.26188500@lxorguk.ukuu.org.uk> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1530 Lines: 36 On Tue, 15 Dec 2009 23:37:38 +0000 Alan Cox wrote: > > > I merged this patch, but made a note-to-self that there are remaining > > > open issues.. > > > > And nothing else happened. Can we revisit this please? > > The last I saw was a request for an explanation of the users > configuration and how he was getting so many misc devices. Its a bug in > dlm if the dlm is doing that but I didn't see any follow up to the DLM > folks on the subject from the reporter, so it stays NACKed and conflicts > with the device registry. > > We need to know from the DLM folks/Thaddeu what is actually going on with > that system, especially as it seems to be producing multiple > registrations of the same misc device name which is completely broken and > should probably be made to error anyway. > > Whatever is going on this is the wrong "fix". If DLM should only register > it once (as seems the intent) then DLM needs fixing or the users config > or both. If it can register many then DLM needs fixing to not eat misc > devices. > > Possibly we need to make it BUG_ON() adding the same name twice, then > perhaps we'd get more feedback > OK, thanks, I dropped it. We can always reappyly it (or a variant) once this is all sorted out. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/