Date: Wed, 16 Dec 2009 08:55:52 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
       containers@lists.linux-foundation.org,
       Andrew Morton <akpm@linux-foundation.org>,
       Balbir Singh <balbir@linux.vnet.ibm.com>,
       Pavel Emelyanov <xemul@openvz.org>, Dan Malek <dan@embeddedalley.com>,
       Vladislav Buzov <vbuzov@embeddedalley.com>,
       Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
       linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH RFC v2 1/4] cgroup: implement eventfd-based generic API
  for notifications
Message-Id: <20091216085552.91ebc559.kamezawa.hiroyu@jp.fujitsu.com>
In-Reply-To: <cc557aab0912150703qcfe6458paa7da71cb032cb93@mail.gmail.com>
References: <cover.1260571675.git.kirill@shutemov.name>
	<ca59c422b495907678915db636f70a8d029cbf3a.1260571675.git.kirill@shutemov.name>
	<cc557aab0912150111k41517b41t8999568db3bd8daa@mail.gmail.com>
	<20091215183533.1a1e87d9.kamezawa.hiroyu@jp.fujitsu.com>
	<cc557aab0912150703qcfe6458paa7da71cb032cb93@mail.gmail.com>
Organization: FUJITSU Co. LTD.
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1148
Lines: 33

On Tue, 15 Dec 2009 17:03:37 +0200
"Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> >> > +       /*
> >> > +        * Unregister events and notify userspace.
> >> > +        * FIXME: How to avoid race with cgroup_event_remove_work()
> >> > +        *        which runs from workqueue?
> >> > +        */
> >> > +       mutex_lock(&cgrp->event_list_mutex);
> >> > +       list_for_each_entry_safe(event, tmp, &cgrp->event_list, list) {
> >> > +               cgroup_event_remove(event);
> >> > +               eventfd_signal(event->eventfd, 1);
> >> > +       }
> >> > +       mutex_unlock(&cgrp->event_list_mutex);
> >> > +
> >> > +out:
> >> >        return ret;
> >> >  }
> >
> > How ciritical is this FIXME ?
> > But Hmm..can't we use RCU ?
> 
> It's not reasonable to have RCU here, since event_list isn't mostly-read.
> 
ok.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/