Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762162AbZLPOhY (ORCPT ); Wed, 16 Dec 2009 09:37:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762176AbZLPOhB (ORCPT ); Wed, 16 Dec 2009 09:37:01 -0500 Received: from mail-pw0-f42.google.com ([209.85.160.42]:59843 "EHLO mail-pw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762170AbZLPOgu (ORCPT ); Wed, 16 Dec 2009 09:36:50 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=vfN/RS1h1D9RyVZFMx+7rgKdEvF3rxuix0GS32MmBLzclOkZbit0VkN1JuVB8oxXh+ Kz7sReLlBJveCpS84auaZdHn0pS9b7aN4mqoll1+rrlZ/enarVItqpo8yjcn/vJaH4NK 4UG7Pu53J7VohP4P3cfFFMVh22+o24mkCqr68= From: Yong Zhang To: linux-kernel@vger.kernel.org Cc: "Juergen E. Fischer" , "James E.J. Bottomley" , linux-scsi@vger.kernel.org Subject: [PATCH 5/5] aha152x: use DECLARE_COMPLETION_ONSTACK for non-constant completion Date: Wed, 16 Dec 2009 22:36:01 +0800 Message-Id: <1260974161-6934-6-git-send-email-yong.zhang0@gmail.com> X-Mailer: git-send-email 1.6.3.3 In-Reply-To: <1260974161-6934-5-git-send-email-yong.zhang0@gmail.com> References: <1260974161-6934-1-git-send-email-yong.zhang0@gmail.com> <1260974161-6934-2-git-send-email-yong.zhang0@gmail.com> <1260974161-6934-3-git-send-email-yong.zhang0@gmail.com> <1260974161-6934-4-git-send-email-yong.zhang0@gmail.com> <1260974161-6934-5-git-send-email-yong.zhang0@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 32 The _ONSTACK variant should be used for on-stack completion, otherwise it will break lockdep. Signed-off-by: Yong Zhang Cc: Juergen E. Fischer Cc: James E.J. Bottomley Cc: linux-scsi@vger.kernel.org --- drivers/scsi/aha152x.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c index 1e5478a..44e43b5 100644 --- a/drivers/scsi/aha152x.c +++ b/drivers/scsi/aha152x.c @@ -1143,7 +1143,7 @@ static int aha152x_abort(Scsi_Cmnd *SCpnt) static int aha152x_device_reset(Scsi_Cmnd * SCpnt) { struct Scsi_Host *shpnt = SCpnt->device->host; - DECLARE_COMPLETION(done); + DECLARE_COMPLETION_ONSTACK(done); int ret, issued, disconnected; unsigned char old_cmd_len = SCpnt->cmd_len; unsigned long flags; -- 1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/