Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762619AbZLPRcZ (ORCPT ); Wed, 16 Dec 2009 12:32:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762589AbZLPRcG (ORCPT ); Wed, 16 Dec 2009 12:32:06 -0500 Received: from mail.perches.com ([173.55.12.10]:1223 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762585AbZLPRcE (ORCPT ); Wed, 16 Dec 2009 12:32:04 -0500 Subject: Re: [PATCH] ep93xx_eth.c: general cleanup From: Joe Perches To: H Hartley Sweeten Cc: kernel list , "Nick M." , Lennert Buytenhek , David Miller In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Wed, 16 Dec 2009 09:32:01 -0800 Message-ID: <1260984721.30093.23.camel@Joe-Laptop.home> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 834 Lines: 25 On Wed, 2009-12-16 at 12:09 -0500, H Hartley Sweeten wrote: > +#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__ I think KBUILD_MODNAME ":%s: " fmt, __func__ or its equivalent direct use is more common. It's possibly useful to standardize. > -#define DRV_MODULE_NAME "ep93xx-eth" > -#define DRV_MODULE_VERSION "0.1" > +#include I think these sorts of defines are common and useful. > static int __init ep93xx_eth_init_module(void) > { > - printk(KERN_INFO DRV_MODULE_NAME " version " DRV_MODULE_VERSION " loading\n"); Why remove this printk completely? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/