Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762704AbZLPSWP (ORCPT ); Wed, 16 Dec 2009 13:22:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762763AbZLPSWJ (ORCPT ); Wed, 16 Dec 2009 13:22:09 -0500 Received: from smtp.nokia.com ([192.100.122.230]:32744 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762762AbZLPSV5 (ORCPT ); Wed, 16 Dec 2009 13:21:57 -0500 Date: Wed, 16 Dec 2009 20:20:22 +0200 From: Felipe Balbi To: "Balbi Felipe (Nokia-D/Helsinki)" Cc: "linux-kernel@vger.kernel.org" , Tony Lindgren , Samuel Ortiz , Santosh Shilimkar , Balaji T K , Rajendra Nayak , Thomas Gleixner , "linux-omap@vger.kernel.org" Subject: Re: [PATCH] mfd: twl4030-irq: irq_desc->lock converted to raw_spinlock_t Message-ID: <20091216182022.GA20302@nokia.com> Reply-To: felipe.balbi@nokia.com References: <1260987530-20221-1-git-send-email-felipe.balbi@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1260987530-20221-1-git-send-email-felipe.balbi@nokia.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginalArrivalTime: 16 Dec 2009 18:20:56.0805 (UTC) FILETIME=[82BE8950:01CA7E7C] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2204 Lines: 67 On Wed, Dec 16, 2009 at 07:18:50PM +0100, Balbi Felipe (Nokia-D/Helsinki) wrote: >commit 239007b8440abff689632f50cdf0f2b9e895b534 converted >the spinlock_t to raw_spinlock_t. Unfortunately twl4030-irq >was left aside on the conversion. > >Cc: Thomas Gleixner >Cc: Tony Lindgre oops, my n is failing. Tony Lindgren, below is better version: ========== cut here ================= From 17edd64d8e813713da6fb9fa018ab5f79d94d159 Mon Sep 17 00:00:00 2001 From: Felipe Balbi Date: Wed, 16 Dec 2009 20:11:22 +0200 Subject: [PATCH] mfd: twl4030-irq: irq_desc->lock converted to raw_spinlock_t commit 239007b8440abff689632f50cdf0f2b9e895b534 converted the spinlock_t to raw_spinlock_t. Unfortunately twl4030-irq was left aside on the conversion. Cc: Thomas Gleixner Cc: Tony Lindgren Cc: linux-omap@vger.kernel.org Signed-off-by: Felipe Balbi --- I'm not sure this is the expected fix since twl4030-irq handler should be running in thread context. Currently mask/unmask/set_type are deferred to a workqueue. Thomas, should this be done ? How do you expect irq chips on slow busses to implement mask/unmask/set_type ? drivers/mfd/twl4030-irq.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index 20d29ba..9df9a5a 100644 --- a/drivers/mfd/twl4030-irq.c +++ b/drivers/mfd/twl4030-irq.c @@ -568,12 +568,12 @@ static void twl4030_sih_do_edge(struct work_struct *work) bytes[byte] &= ~(0x03 << off); - spin_lock_irq(&d->lock); + raw_spin_lock_irq(&d->lock); if (d->status & IRQ_TYPE_EDGE_RISING) bytes[byte] |= BIT(off + 1); if (d->status & IRQ_TYPE_EDGE_FALLING) bytes[byte] |= BIT(off + 0); - spin_unlock_irq(&d->lock); + raw_spin_unlock_irq(&d->lock); edge_change &= ~BIT(i); } -- 1.6.6.rc0 -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/