Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935329AbZLPTAi (ORCPT ); Wed, 16 Dec 2009 14:00:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935287AbZLPTAc (ORCPT ); Wed, 16 Dec 2009 14:00:32 -0500 Received: from d112.x-mailer.de ([212.162.53.3]:59462 "EHLO d112a3.x-mailer.de" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S935273AbZLPTA0 (ORCPT ); Wed, 16 Dec 2009 14:00:26 -0500 From: Karsten Keil To: Yong Zhang Subject: Re: [PATCH 4/5] mISDN: use DECLARE_COMPLETION_ONSTACK for non-constant completion Date: Wed, 16 Dec 2009 20:00:20 +0100 User-Agent: KMail/1.12.2 (Linux/2.6.27.37-0.1-default; KDE/4.3.1; x86_64; ; ) Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Andreas Eversberg , Arnaldo Carvalho de Melo References: <1260974161-6934-1-git-send-email-yong.zhang0@gmail.com> <1260974161-6934-4-git-send-email-yong.zhang0@gmail.com> <1260974161-6934-5-git-send-email-yong.zhang0@gmail.com> In-Reply-To: <1260974161-6934-5-git-send-email-yong.zhang0@gmail.com> Organization: B1-systems MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Message-Id: <200912162000.20642.keil@b1-systems.de> X-Info: valid message X-Info: original Date Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1127 Lines: 31 The _ONSTACK variant should be used for on-stack completion, otherwise it will break lockdep. Signed-off-by: Yong Zhang Acked-by: Karsten Keil Cc: David S. Miller Cc: Andreas Eversberg Cc: Arnaldo Carvalho de Melo --- drivers/isdn/mISDN/l1oip_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/mISDN/l1oip_core.c b/drivers/isdn/mISDN/l1oip_core.c index 7e5f30d..f1e8af5 100644 --- a/drivers/isdn/mISDN/l1oip_core.c +++ b/drivers/isdn/mISDN/l1oip_core.c @@ -661,7 +661,7 @@ l1oip_socket_thread(void *data) size_t recvbuf_size = 1500; int recvlen; struct socket *socket = NULL; - DECLARE_COMPLETION(wait); + DECLARE_COMPLETION_ONSTACK(wait); /* allocate buffer memory */ recvbuf = kmalloc(recvbuf_size, GFP_KERNEL); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/