DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=okmijgVUkpjjydxokjoHulFkjDyiQTZswCEVyvQPI693dh+4n7jhD5P7HZwexvk1rx
         BVF7I7mQrz81L+/Kp9foYZokK3M2DQsXOOH8iiE1aPa0Os/4Xn6GGMT8qp/o4Zxz4CzO
         0afqyp+OaZ77OhQ1q4Iig/NfN2dkEFF+JIWNE=
MIME-Version: 1.0
In-Reply-To: <20419.1260982769@redhat.com>
References: <1260921350-6539-1-git-send-email-vapier@gentoo.org> 
	<20419.1260982769@redhat.com>
From: Mike Frysinger <vapier.adi@gmail.com>
Date: Wed, 16 Dec 2009 14:36:32 -0500
Message-ID: <8bd0f97a0912161136g19fdc4eeif977b56c98464f8b@mail.gmail.com>
Subject: Re: [uClinux-dev] Re: [PATCH] NOMMU: add [stack] label to per-process 
	maps output
To: uClinux development list <uclinux-dev@uclinux.org>
Cc: linux-kernel@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>,
       uclinux-dist-devel@blackfin.uclinux.org,
       David McCullough <davidm@snapgear.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 784
Lines: 18

On Wed, Dec 16, 2009 at 11:59, David Howells wrote:
> Mike Frysinger wrote:
>
>> +             if (vma->vm_start <= mm->start_brk &&
>> +                             vma->vm_end >= mm->brk) {
>
> Hmmm...  That ought to involve mm->start_stack somewhere...  (Or, more
> probably, task->stack_start:-/)

in practice, it's probably always the same result, but you're right of
course.  when i looked through the elf_fdpic code, i looked at the
start_brk mmap() and missed the later start_stack assignment later on.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/