Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933512AbZLPV6U (ORCPT ); Wed, 16 Dec 2009 16:58:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932402AbZLPV6R (ORCPT ); Wed, 16 Dec 2009 16:58:17 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:65235 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932376AbZLPV6Q (ORCPT ); Wed, 16 Dec 2009 16:58:16 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=n/F7Qcxs78CQzIT8aUIW4Zb1t0m/PgdhF0Y2JPLE9aDMlop2jIGjaFq9RyPg8rk+Z9 UN2+c6iQZsHeLBB46BAcAGGVvsYwobRSAK12AZ65cKgH3FdBPE+ZuxtqC+KyoLX6UDyf 2TcwA19btVKV6HeGVYR4xh1eFlEAY1HSi19gI= Date: Wed, 16 Dec 2009 22:58:08 +0100 From: Borislav Petkov To: Randy Dunlap Cc: "H. Peter Anvin" , Borislav Petkov , Stephen Rothwell , linux-next@vger.kernel.org, LKML Subject: Re: [PATCH -next] x86 msrs: alloc/free for CONFIG_SMP=n Message-ID: <20091216215808.GB27228@liondog.tnic> Mail-Followup-To: Borislav Petkov , Randy Dunlap , "H. Peter Anvin" , Borislav Petkov , Stephen Rothwell , linux-next@vger.kernel.org, LKML References: <20091216183212.118c5e14.sfr@canb.auug.org.au> <20091216092424.5f87214c.randy.dunlap@oracle.com> <4B2919BD.40001@zytor.com> <20091216174524.GH11618@aftab> <4B2928AC.3020807@zytor.com> <20091216135119.e283e525.randy.dunlap@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20091216135119.e283e525.randy.dunlap@oracle.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 39 On Wed, Dec 16, 2009 at 01:51:19PM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > Rearrange arch/x86/lib/msr.c so that alloc/free are built and > usable when CONFIG_SMP=n. Fixes build of amd64_edac. > > ERROR: "msrs_free" [drivers/edac/amd64_edac_mod.ko] undefined! > ERROR: "msrs_alloc" [drivers/edac/amd64_edac_mod.ko] undefined! > > --- > arch/x86/lib/Makefile | 2 - > arch/x86/lib/msr.c | 42 ++++++++++++++++++++-------------------- > 2 files changed, 23 insertions(+), 21 deletions(-) Haha, I just sent a very similar one :) > > --- linux-next-20091216.orig/arch/x86/lib/Makefile > +++ linux-next-20091216/arch/x86/lib/Makefile > @@ -14,7 +14,7 @@ $(obj)/inat.o: $(obj)/inat-tables.c > > clean-files := inat-tables.c > > -obj-$(CONFIG_SMP) := msr.o > +obj-$(CONFIG_X86_MSR) := msr.o however, CONFIG_X86_MSR is the x86 MSR access module and the is the library of MSR accessing functions which is always in. So this should be unconditional as in my version or Peter might have a better idea...? -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/