DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
        b=FWf6vb6lzvlQwU8hbW1ONCjt30/RdbnuzNAjxTeQIFaOKJSZ6ciGB4SZYPufab5NvO
         O040dU/lTJadP8Gr6sOqwHUn4DQ9eHi/5U4ua5UlQoiFPdxcdLtYzX56K4F0ndV+FRi/
         /kwPehMMQEKr+55IbVAHln663L89fKsR95QDE=
MIME-Version: 1.0
In-Reply-To: <20091207190947.GF27692@thunk.org>
References: <1daf33050912011730l5def95brac3ce60647bc2040@mail.gmail.com>
	 <20091207190947.GF27692@thunk.org>
Date: Wed, 16 Dec 2009 19:42:35 -0500
Message-ID: <def8f7750912161642v16dd7bbflaf78bd0d231af68d@mail.gmail.com>
Subject: Re: [PATCH] ext2/3 as ext4
From: Philip Wernersbach <philip.wernersbach@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: tytso@mit.edu, Pavel Machek <pavel@ucw.cz>,
       Richard Holden <aciddeath@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1233
Lines: 36

> Why the open coded strcmp?
strcmp is a C standard library function, not a C builtin, thus it
can't be used in the kernel.

> I would put these 2 conditionals into a single if ||, and consolidate
> the type_page setting into 1 place, then you limit where you handle the
> ext2/ext3 filesystems inside of ext4.
Thanks, that's a good idea.

> (I believe patch was whitespace damaged).
Oops! It was, sorry about that.

> Add yourself to the CREDITS; we don't use comments for changelog these days.
Okay.

> Ouch?
I don't see the problem, please elaborate.

> Can you use memcmp, instead?
No, it's a C standard library function.

> Actualy strcmp() may be appropriate.
It would, but that's also a C standard library function.

> Here's a much cleaner patch which achieves the same goal...
Thanks Ted, that is much cleaner, although I think it would be better
to have separate KCONFIG options for mounting ext2 as ext4 and ext3 as
ext4. I can code this in when I get some time.

Thanks,
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/