Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754859AbZLQFru (ORCPT ); Thu, 17 Dec 2009 00:47:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753121AbZLQFro (ORCPT ); Thu, 17 Dec 2009 00:47:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53349 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753915AbZLQFrl (ORCPT ); Thu, 17 Dec 2009 00:47:41 -0500 Message-ID: <4B29C652.5080803@redhat.com> Date: Thu, 17 Dec 2009 00:49:06 -0500 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: "H. Peter Anvin" CC: Roland Dreier , Michal Marek , Andrew Isaacson , Ingo Molnar , x86@kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Rob Landley Subject: Re: CONFIG_KPROBES=y build requires gawk References: <20091216235617.GA12267@hexapodia.org> <4B29A686.9070603@redhat.com> <4B29BA13.7020502@redhat.com> <4B29BFE8.1000502@zytor.com> In-Reply-To: <4B29BFE8.1000502@zytor.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1320 Lines: 49 H. Peter Anvin wrote: > On 12/16/2009 09:11 PM, Roland Dreier wrote: >> >> > As Al Viro said, if we run awk with LC_ALL=C, then the characters will be >> > sorted as ASCII. So, your patch is OK if you can add LC_ALL=C just before >> > $(AWK). (I'm not so sure whether Makefile can accept it...) >> > > I would strongly prefer the following solution as it solves this entire > class of problems globally, although I'd really want Michal's ACK for it: Sure, agreed. BTW, is it possible user to overwrite this setting? Thank you, > > diff --git a/Makefile b/Makefile > index 33d4732..7fefc13 100644 > --- a/Makefile > +++ b/Makefile > @@ -302,6 +302,10 @@ MAKEFLAGS += --include-dir=$(srctree) > $(srctree)/scripts/Kbuild.include: ; > include $(srctree)/scripts/Kbuild.include > > +# Avoid funny character set dependencies > +LC_ALL=C > +export LC_ALL > + > # Make variables (CC, etc...) > > AS = $(CROSS_COMPILE)as > > -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/