Date: Thu, 17 Dec 2009 07:47:37 +0100
Message-ID: <s5hfx7aw0za.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Troy Kisky <troy.kisky@boundarydevices.com>
Cc: Roel Kluin <roel.kluin@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
       alsa-devel@alsa-project.org, Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] sound/oss/pss: Fix test of unsigned in pss_reset_dsp() and pss_download_boot()
In-Reply-To: <4B2979E7.7060305@boundarydevices.com>
References: <4B28085A.6020101@gmail.com>
	<4B2979E7.7060305@boundarydevices.com>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1044
Lines: 34

At Wed, 16 Dec 2009 17:23:03 -0700,
Troy Kisky wrote:
> 
> Roel Kluin wrote:
> > limit and jiffies are unsigned so the test does not work.
> > 
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > ---
> > Found using coccinelle: http://coccinelle.lip6.fr/
> > 
> > diff --git a/sound/oss/pss.c b/sound/oss/pss.c
> > index 83f5ee2..9325f4d 100644
> > --- a/sound/oss/pss.c
> > +++ b/sound/oss/pss.c
> > @@ -269,7 +269,7 @@ static int pss_reset_dsp(pss_confdata * devc)
> >  	unsigned long   i, limit = jiffies + HZ/10;
> >  
> >  	outw(0x2000, REG(PSS_CONTROL));
> > -	for (i = 0; i < 32768 && (limit-jiffies >= 0); i++)
> 
> I think
> 	for (i = 0; i < 32768 && ( (int)(limit-jiffies) >= 0); i++)
> 
> works better when jiffies wrap

Yes, and time_after_eq() takes care of it nicely :)


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/