Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965029AbZLQLfH (ORCPT ); Thu, 17 Dec 2009 06:35:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964994AbZLQLfB (ORCPT ); Thu, 17 Dec 2009 06:35:01 -0500 Received: from cantor.suse.de ([195.135.220.2]:40402 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964995AbZLQLfA (ORCPT ); Thu, 17 Dec 2009 06:35:00 -0500 Message-ID: <4B2A1761.4070904@suse.cz> Date: Thu, 17 Dec 2009 12:34:57 +0100 From: Michal Marek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.2 Thunderbird/3.0 MIME-Version: 1.0 To: Sam Ravnborg Cc: "H. Peter Anvin" , Roland Dreier , Masami Hiramatsu , Andrew Isaacson , Ingo Molnar , x86@kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Rob Landley Subject: Re: CONFIG_KPROBES=y build requires gawk References: <20091216235617.GA12267@hexapodia.org> <4B29A686.9070603@redhat.com> <4B29BA13.7020502@redhat.com> <20091217054524.GA3931@merkur.ravnborg.org> <4B29C81E.2000704@zytor.com> <20091217080900.GA4010@merkur.ravnborg.org> In-Reply-To: <20091217080900.GA4010@merkur.ravnborg.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2059 Lines: 56 On 17.12.2009 09:09, Sam Ravnborg wrote: > On Wed, Dec 16, 2009 at 09:56:46PM -0800, H. Peter Anvin wrote: >> On 12/16/2009 09:45 PM, Sam Ravnborg wrote: >>>> >>>> diff --git a/arch/x86/lib/Makefile b/arch/x86/lib/Makefile >>>> index 45b20e4..0c46d60 100644 >>>> --- a/arch/x86/lib/Makefile >>>> +++ b/arch/x86/lib/Makefile >>>> @@ -5,7 +5,7 @@ >>>> inat_tables_script = $(srctree)/arch/x86/tools/gen-insn-attr-x86.awk >>>> inat_tables_maps = $(srctree)/arch/x86/lib/x86-opcode-map.txt >>>> quiet_cmd_inat_tables = GEN $@ >>>> - cmd_inat_tables = $(AWK) -f $(inat_tables_script) $(inat_tables_maps) > $@ || rm -f $@ >>>> + cmd_inat_tables = LC_ALL=C $(AWK) -f $(inat_tables_script) $(inat_tables_maps) > $@ || rm -f $@ >>> >>> This will result in error messages in english always from awk - no? >>> Some people will care. >>> >> >> True, we probably don't want to set LC_MESSAGES. Which means: >> >> diff --git a/Makefile b/Makefile >> index 33d4732..357e83b 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -302,6 +302,13 @@ MAKEFLAGS += --include-dir=$(srctree) >> $(srctree)/scripts/Kbuild.include: ; >> include $(srctree)/scripts/Kbuild.include >> >> +# Avoid funny character set dependencies >> +LC_ALL= >> +LC_CTYPE=C >> +LC_COLLATE=C >> +LC_NUMERIC=C >> +export LC_ALL LC_CTYPE LC_COLLATE LC_NUMERIC >> + >> # Make variables (CC, etc...) >> >> AS = $(CROSS_COMPILE)as > > Took a closer look at the patch. > I think we should move this upwards in the Makefile so it take effect as soon as possible. > Around the line where we do: > > MAKEFLAGS += -rR --no-print-directory There are only some variable assignments and a sed call in the SUBARCH definition, but right, to be 100% sure that in the future there won't appear anything locale-dependent, we should move it upwards. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/