Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764752AbZLQQjz (ORCPT ); Thu, 17 Dec 2009 11:39:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764360AbZLQQjt (ORCPT ); Thu, 17 Dec 2009 11:39:49 -0500 Received: from mail.dev.rtsoft.ru ([213.79.90.226]:33978 "HELO mail.dev.rtsoft.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1764425AbZLQQjq (ORCPT ); Thu, 17 Dec 2009 11:39:46 -0500 Date: Thu, 17 Dec 2009 19:39:44 +0300 From: Anton Vorontsov To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: linux-kernel@vger.kernel.org, David Vrabel , Greg Kroah-Hartman , David Brownell , Grant Likely , Kumar Gala , Andrew Morton , spi-devel-general@lists.sourceforge.net Subject: Re: [PATCH 6/7] spi/mpc8xxx: don't check platform_get_irq's return value against zero Message-ID: <20091217163944.GA6453@oksana.dev.rtsoft.ru> Reply-To: avorontsov@ru.mvista.com References: <1260979809-24811-1-git-send-email-u.kleine-koenig@pengutronix.de> <1260979809-24811-2-git-send-email-u.kleine-koenig@pengutronix.de> <1260979809-24811-3-git-send-email-u.kleine-koenig@pengutronix.de> <1260979809-24811-4-git-send-email-u.kleine-koenig@pengutronix.de> <1260979809-24811-5-git-send-email-u.kleine-koenig@pengutronix.de> <1260979809-24811-6-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1260979809-24811-6-git-send-email-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1842 Lines: 47 On Wed, Dec 16, 2009 at 05:10:08PM +0100, Uwe Kleine-König wrote: > platform_get_irq returns -ENXIO on failure, so !irq was probably > always true. Better use (int)irq <= 0. Note that a return value of > zero is still handled as error even though this could mean irq0. > > This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that > changed the return value of platform_get_irq from 0 to -ENXIO on error. > > Signed-off-by: Uwe Kleine-König > Cc: David Vrabel > Cc: Greg Kroah-Hartman > Cc: David Brownell > Cc: Grant Likely > Cc: Kumar Gala > Cc: Anton Vorontsov > Cc: Andrew Morton > Cc: spi-devel-general@lists.sourceforge.net > --- > drivers/spi/spi_mpc8xxx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c > index e9390d7..b13501a 100644 > --- a/drivers/spi/spi_mpc8xxx.c > +++ b/drivers/spi/spi_mpc8xxx.c > @@ -1339,7 +1339,7 @@ static int __devinit plat_mpc8xxx_spi_probe(struct platform_device *pdev) > return -EINVAL; > > irq = platform_get_irq(pdev, 0); > - if (!irq) > + if ((int)irq <= 0) I tend to think that it's really hopeless to fix the platform_get_irq() in its current form, so can you get rid of this ugly cast and just make the irq signed? And I'll be fine with it. :-( -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/