Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934413AbZLQRWN (ORCPT ); Thu, 17 Dec 2009 12:22:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764996AbZLQRVy (ORCPT ); Thu, 17 Dec 2009 12:21:54 -0500 Received: from mga14.intel.com ([143.182.124.37]:25899 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759486AbZLQRVx (ORCPT ); Thu, 17 Dec 2009 12:21:53 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.47,316,1257148800"; d="scan'208";a="224080642" Date: Thu, 17 Dec 2009 09:21:49 -0800 (Pacific Standard Time) From: "Brandeburg, Jesse" To: Roger Oksanen cc: Alan Stern , "Kirsher, Jeffrey T" , "Allan, Bruce W" , "Waskiewicz Jr, Peter P" , "Ronciak, John" , "e1000-devel@lists.sourceforge.net" , Kernel development list , "netdev@vger.kernel.org" , David Miller Subject: Re: e100 REGRESSION in 2.6.32 (PATCH v2) In-Reply-To: <200912171810.45575.roger.oksanen@cs.helsinki.fi> Message-ID: References: <200912171810.45575.roger.oksanen@cs.helsinki.fi> User-Agent: Alpine 2.00 (WNT 1167 2008-08-23) ReplyTo: "Brandeburg, Jesse" X-X-Sender: amrjbrandeb@imapmail.glb.intel.com MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1094 Lines: 27 On Thu, 17 Dec 2009, Roger Oksanen wrote: > e100: Fix broken cbs accounting due to missing memset. > > Alan Stern noticed that e100 caused slab corruption. > commit 98468efddb101f8a29af974101c17ba513b07be1 changed > the allocation of cbs to use dma pools that don't return zeroed memory, > especially the cb->status field used to track which cb to clean, causing > (the visible) double freeing of skbs and a wrong free cbs count. > > Now the cbs are explicitly zeroed at allocation time. > > Reported-by: Alan Stern > Tested-by: Alan Stern > Signed-off-by: Roger Oksanen Change looks reasonable, ACK. should we also consider a followon patch to zero memory allocated with pci_pools? Seems useful. Acked-by: Jesse Brandeburg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/