Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965336AbZLQTGe (ORCPT ); Thu, 17 Dec 2009 14:06:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965329AbZLQTGb (ORCPT ); Thu, 17 Dec 2009 14:06:31 -0500 Received: from outbound-mail-132.bluehost.com ([67.222.39.22]:49391 "HELO outbound-mail-132.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S965327AbZLQTG3 convert rfc822-to-8bit (ORCPT ); Thu, 17 Dec 2009 14:06:29 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org; h=Received:Date:From:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=L1QX0O90sCio991b+ve5DQjpF1ZIilitUsrePBCwCgquzgVoVoCqZl2mqhW9gBPizU58UkA+rWg66/rebzwFu8aD1UcHXOMPRa1aUhU+nHCQqp/MuU6owjMcvVtsYDOI; Date: Thu, 17 Dec 2009 11:05:56 -0800 From: Jesse Barnes Cc: Emmanuel Benisty , Darren Salt , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, luto@myrealbox.com, eric@anholt.net Subject: Re: 2.6.31 -> 2.6.32 Sound and video regressions Message-ID: <20091217110556.0b103125@jbarnes-piketon> In-Reply-To: <20091210095422.3c5a75d1@jbarnes-piketon> References: <4B1A6F78.8010408@myrealbox.com> <50CA8D92EC%linux@youmustbejoking.demon.co.uk> <20091206173222.4c2d5aaa@jbarnes-piketon> <20091210095422.3c5a75d1@jbarnes-piketon> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.18.3; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 75.111.28.251 authed with jbarnes@virtuousgeek.org} To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3700 Lines: 91 On Thu, 10 Dec 2009 09:54:22 -0800 Jesse Barnes wrote: > On Tue, 8 Dec 2009 20:20:07 +0700 > Emmanuel Benisty wrote: > > > On Mon, Dec 7, 2009 at 8:38 PM, Emmanuel Benisty > > wrote: > > > On Mon, Dec 7, 2009 at 10:52 AM, Emmanuel Benisty > > > wrote: > > >> On Mon, Dec 7, 2009 at 8:32 AM, Jesse Barnes > > >> wrote: > > >>> On Sat, 05 Dec 2009 23:44:55 +0000 > > >>> Darren Salt wrote: > > >>> > > >>>> I demand that Andy Lutomirski may or may not have written... > > >>>> > > >>>> > Emmanuel Benisty wrote: > > >>>> [snip] > > >>>> >> I just wanted to report 2 regressions I am having now with > > >>>> >> 2.6.32. Video > > >>>> >> Screen is flickering/glitching like crazy in X. It happens > > >>>> >> whether randomly or when conky is refreshed, when the mouse > > >>>> >> cursor moves and like hell when a page is loading in the > > >>>> >> browser. Not so easy to describe this issue. > > >>>> [snip] > > >>>> > > >>>> > That sounds like FIFO underruns, which (I think) were > > >>>> > introduced when self-refresh was enabled but should have been > > >>>> > fixed. I personally have no clue how to fix them, but if you > > >>>> > told the Intel people what kind of chip you have (lspci > > >>>> > output), they can probably fix it. > > >>>> > > >>>> It also sounds like what I'm seeing on my EeePC 901. It only > > >>>> happens after resume, which makes STR a little less than > > >>>> useful; the display will, sooner or later, show a single > > >>>> colour (which is, presumably, the result of a display engine > > >>>> hang, as described in the comment immediately before > > >>>> intel_calculate_wm) and, seemingly, be stuck like that until > > >>>> power-off or reboot. > > >>>> > > >>>> Whether it *is* the same problem, I couldn't say. > > >>>> > > >>>> Needless to say, this problem goes away if I disable KMS. > > >>> > > >>> Arg, there are a few reports of this now, but I haven't been > > >>> able to reproduce it.  I'll try harder...  (FYI the upstream > > >>> bugs.freedesktop.org # for it is 24314). > > >> > > >> It *seems* that we are facing two different issues here (I don't > > >> even use S2R and the problem is there since the very first second > > >> I start X). Anyway, I have bisected the problem on my box, it > > >> turns out to be this one: > > >> > > >> drm/i915: Fix render reclock availability detection > > >> > > >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=181a5336d6cc836f05507410d66988c483ad0154 > > >> > > > So, I have reverted this commit and rebuilt 2.6.32. It completely > > > solved the issue described in my first post. > > > > > > > just FTR, it looks like I'm not alone: > > http://forums.gentoo.org/viewtopic-p-6087556.html#6087556 > > Great, thanks for narrowing it down. I'll see if I can come up with a > fix. Can you give this a try? -- Jesse Barnes, Intel Open Source Technology Center diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_d index 279dc96..5bde801 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -3808,6 +3808,8 @@ void intel_decrease_renderclock(struct drm_device *dev) { drm_i915_private_t *dev_priv = dev->dev_private; + return; + if (IS_IRONLAKE(dev)) return; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/