Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764888AbZLQU0X (ORCPT ); Thu, 17 Dec 2009 15:26:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764885AbZLQU0M (ORCPT ); Thu, 17 Dec 2009 15:26:12 -0500 Received: from mail.gmx.net ([213.165.64.20]:33670 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1764572AbZLQU0G convert rfc822-to-8bit (ORCPT ); Thu, 17 Dec 2009 15:26:06 -0500 X-Authenticated: #20450766 X-Provags-ID: V01U2FsdGVkX18ttAp7LdYtQJHC2+HH6sS4gXhnB2VeMWrnUWLOEU t7DtPyJGhry452 Date: Thu, 17 Dec 2009 21:25:52 +0100 (CET) From: Guennadi Liakhovetski To: Andrew Morton cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Ian Molton Subject: Re: [PATCH/RFC] tmio_mmc: keep card-detect interrupts enabled In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=KOI8-R Content-Transfer-Encoding: 8BIT X-Y-GMX-Trusted: 0 X-FuHaFi: 0.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4883 Lines: 135 Hi Andrew I originally submitted this [1] patch on the 6th of November, then accidentally the MMC list got dropped from CC and the discussion moved to another irrelevant list, Ian's last reply is at [2]. Unfortunately, Ian hasn't replied to my reminders since then, and I don't see this patch anywhere upstream. Is there any way we could get it into 2.6.33? Thanks Guennadi [1] http://thread.gmane.org/gmane.linux.kernel.mmc/704 [2] http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/11981/focus=11995 On Wed, 16 Dec 2009, Guennadi Liakhovetski wrote: > On Sat, 28 Nov 2009, Guennadi Liakhovetski wrote: > > > On Tue, 10 Nov 2009, Ian Molton wrote: > > > > > Well if they are only masked they shouldnt stop being asserted. But we > > > should unmask them again. > > > > > > Im not really sure we should mask them anyway, with the card possibly > > > being gone... Will need to look into it further. > > > > Hi Ian > > > > What's the status of this patch? Are you going to queue it for 2.6.33? > > Ian, ping? I still don't see this patch in any (Linus' / next) upstream > tree and the merge window will be closing soon. Any update? > > Thanks > Guennadi > > > > > Thanks > > Guennadi > > > > > > > > 2009/11/9 Guennadi Liakhovetski : > > > > (re-adding accidentally dropped ML) > > > > > > > > On Mon, 9 Nov 2009, Ian Molton wrote: > > > > > > > >> Well, I presume we want to know when the card gets removed :) > > > > > > > > Sure, that's why we shouldn't mask those interrupts:-) If they do get > > > > masked and missed, I do not know, if the interrupt remains pending in this > > > > case, because they never get detected then:) > > > > > > > >> > > > >> 2009/11/9 Guennadi Liakhovetski : > > > >> > Hi Ian > > > >> > > > > >> > Why did you drop all CCs? > > > >> > > > > >> > On Mon, 9 Nov 2009, Ian Molton wrote: > > > >> > > > > >> >> I havent looked at the consequences for the driver if a insert IRQ > > > >> >> occurs during IO, however it seems logical that we should not > > > >> >> permanently mask the IRQ. > > > >> >> > > > >> >> I presume that the IRQ remains pending? > > > >> > > > > >> > Don't know, never checked. Is this important to know? > > > >> > > > > >> > Thanks > > > >> > Guennadi > > > >> > > > > >> >> > > > >> >> 2009/11/6 Guennadi Liakhovetski : > > > >> >> > On SuperH platforms the SDHI controller does not produce any command IRQs > > > >> >> > after a completed IO. This leads to card-detect interrupts staying > > > >> >> > disabled. Do not disable card-detect interrupts on DATA IRQs. > > > >> >> > > > > >> >> > Signed-off-by: Guennadi Liakhovetski > > > >> >> > --- > > > >> >> > > > > >> >> > Marked as RFC because I'm not really sure this is a correct approach to > > > >> >> > fix this problem, and whether this will have negative effect on other > > > >> >> > tmio_mmc MFD users. > > > >> >> > > > > >> >> > diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h > > > >> >> > index c676767..0b31d44 100644 > > > >> >> > --- a/drivers/mmc/host/tmio_mmc.h > > > >> >> > +++ b/drivers/mmc/host/tmio_mmc.h > > > >> >> > @@ -55,10 +55,8 @@ > > > >> >> > ?/* Define some IRQ masks */ > > > >> >> > ?/* This is the mask used at reset by the chip */ > > > >> >> > ?#define TMIO_MASK_ALL ? ? ? ? ? 0x837f031d > > > >> >> > -#define TMIO_MASK_READOP ?(TMIO_STAT_RXRDY | TMIO_STAT_DATAEND | \ > > > >> >> > - ? ? ? ? ? ? ? TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT) > > > >> >> > -#define TMIO_MASK_WRITEOP (TMIO_STAT_TXRQ | TMIO_STAT_DATAEND | \ > > > >> >> > - ? ? ? ? ? ? ? TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT) > > > >> >> > +#define TMIO_MASK_READOP ?(TMIO_STAT_RXRDY | TMIO_STAT_DATAEND) > > > >> >> > +#define TMIO_MASK_WRITEOP (TMIO_STAT_TXRQ | TMIO_STAT_DATAEND) > > > >> >> > ?#define TMIO_MASK_CMD ? ? (TMIO_STAT_CMDRESPEND | TMIO_STAT_CMDTIMEOUT | \ > > > >> >> > ? ? ? ? ? ? ? ?TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT) > > > >> >> > ?#define TMIO_MASK_IRQ ? ? (TMIO_MASK_READOP | TMIO_MASK_WRITEOP | TMIO_MASK_CMD) > > > > > > > > Thanks > > > > Guennadi > > > > --- > > > > Guennadi Liakhovetski, Ph.D. > > > > Freelance Open-Source Software Developer > > > > http://www.open-technology.de/ > > > > > > > > > > > > > > > > -- > > > Ian Molton > > > Linux, Automotive, and other hacking: > > > http://www.mnementh.co.uk/ > > > > > > > --- > > Guennadi Liakhovetski > > > > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/ > --- Guennadi Liakhovetski -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/