Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765345AbZLQVPj (ORCPT ); Thu, 17 Dec 2009 16:15:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765320AbZLQVPf (ORCPT ); Thu, 17 Dec 2009 16:15:35 -0500 Received: from smtp-out.google.com ([216.239.33.17]:62225 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765262AbZLQVPc convert rfc822-to-8bit (ORCPT ); Thu, 17 Dec 2009 16:15:32 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:from:date:message-id: subject:to:cc:content-type:content-transfer-encoding:x-system-of-record; b=TUY2SLhRyJJ1S5gzk1xSuD4MrgHVXlGyqXqyjcqDuDKwWX3RAOSYtOuGqz3bD5KLM Z6ATVNejditw9Vv8yH0tg== MIME-Version: 1.0 In-Reply-To: References: <200912171810.45575.roger.oksanen@cs.helsinki.fi> From: Laurent Chavey Date: Thu, 17 Dec 2009 13:15:04 -0800 Message-ID: <97949e3e0912171315g537903f7m9461ea8399dc018c@mail.gmail.com> Subject: Re: e100 REGRESSION in 2.6.32 (PATCH v2) To: "Brandeburg, Jesse" Cc: Roger Oksanen , Alan Stern , "Kirsher, Jeffrey T" , "Allan, Bruce W" , "Waskiewicz Jr, Peter P" , "Ronciak, John" , "e1000-devel@lists.sourceforge.net" , Kernel development list , "netdev@vger.kernel.org" , David Miller Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1540 Lines: 39 when using DMAPOOL_DEBUG, do we really want to over-write memset(retval, POOL_POISON_ALLOCATED, pool->size); set in dma_pool_alloc. On Thu, Dec 17, 2009 at 9:21 AM, Brandeburg, Jesse wrote: > > On Thu, 17 Dec 2009, Roger Oksanen wrote: >> e100: Fix broken cbs accounting due to missing memset. >> >> Alan Stern noticed that e100 caused slab corruption. >> commit 98468efddb101f8a29af974101c17ba513b07be1 changed >> the allocation of cbs to use dma pools that don't return zeroed memory, >> especially the cb->status field used to track which cb to clean, causing >> (the visible) double freeing of skbs and a wrong free cbs count. >> >> Now the cbs are explicitly zeroed at allocation time. >> >> Reported-by: Alan Stern >> Tested-by: Alan Stern >> Signed-off-by: Roger Oksanen > > Change looks reasonable, ACK. > > should we also consider a followon patch to zero memory allocated with > pci_pools? ?Seems useful. > > Acked-by: Jesse Brandeburg > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at ?http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/