Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752105AbZLRAIW (ORCPT ); Thu, 17 Dec 2009 19:08:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751799AbZLRAIQ (ORCPT ); Thu, 17 Dec 2009 19:08:16 -0500 Received: from terminus.zytor.com ([198.137.202.10]:35788 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751224AbZLRAIM (ORCPT ); Thu, 17 Dec 2009 19:08:12 -0500 Message-ID: <4B2AC7C0.6040801@zytor.com> Date: Thu, 17 Dec 2009 16:07:28 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Thunderbird/3.0b4 MIME-Version: 1.0 To: Masami Hiramatsu CC: mingo@redhat.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tglx@linutronix.de, mingo@elte.hu, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/urgent] x86: Fix objdump version check in arch/x86/tools/chkobjdump.awk References: <200912172326.nBHNQaQl024796@imap1.linux-foundation.org> <4B2AC710.2090705@redhat.com> In-Reply-To: <4B2AC710.2090705@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1378 Lines: 37 On 12/17/2009 04:04 PM, Masami Hiramatsu wrote: >> >> Warning: objdump version is older than 2.19 >> Warning: Skipping posttest. >> >> because it used the wrong field from `objdump -v': >> >> akpm:/usr/src/25> /opt/crosstool/gcc-4.0.2-glibc-2.3.6/x86_64-unknown-linux-gnu/bin/x86_64-unknown-linux-gnu-objdump -v >> GNU objdump 2.16.1 >> Copyright 2005 Free Software Foundation, Inc. >> This program is free software; you may redistribute it under the terms of >> the GNU General Public License. This program has absolutely no warranty. > > > Oh, I didn't know that. > On my environment, objdump shows version in below format. > --- > $ objdump -v > GNU objdump version 2.19.51.0.14-1.fc11 20090722 > Copyright 2008 Free Software Foundation, Inc. > This program is free software; you may redistribute it under the terms of > the GNU General Public License version 3 or (at your option) any later version. > This program has absolutely no warranty. > --- > > Hmm, maybe, we need to check if ($3 == "version") to decide > which argument we should use. > How about looking for the first argument that starts with a number? -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/