Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754260AbZLREaS (ORCPT ); Thu, 17 Dec 2009 23:30:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753514AbZLREaQ (ORCPT ); Thu, 17 Dec 2009 23:30:16 -0500 Received: from lennier.cc.vt.edu ([198.82.162.213]:41985 "EHLO lennier.cc.vt.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbZLREaO (ORCPT ); Thu, 17 Dec 2009 23:30:14 -0500 X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2 To: Mikulas Patocka Cc: Krzysztof Halasa , Paul Mundt , linux-kernel@vger.kernel.org, Linus Torvalds , Alasdair G Kergon , dm-devel@redhat.com Subject: Re: [PATCH] Drop 80-character limit in checkpatch.pl In-Reply-To: Your message of "Thu, 17 Dec 2009 18:29:25 EST." From: Valdis.Kletnieks@vt.edu References: <20091217061229.GD3946@linux-sh.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1261110557_3855P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Thu, 17 Dec 2009 23:29:17 -0500 Message-ID: <24653.1261110557@localhost> X-Mirapoint-Received-SPF: 128.173.34.103 localhost Valdis.Kletnieks@vt.edu 2 pass X-Mirapoint-IP-Reputation: reputation=neutral-1, source=Fixed, refid=n/a, actions=MAILHURDLE SPF TAG X-Junkmail-Info: (45) HELO_LOCALHOST X-Junkmail-Status: score=45/50, host=zidane.cc.vt.edu X-Junkmail-SD-Raw: score=unknown, refid=str=0001.0A020206.4B2B051E.0202,ss=1,fgs=0, ip=0.0.0.0, so=2009-09-22 00:05:22, dmn=2009-09-10 00:05:08, mode=multiengine X-Junkmail-IWF: false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1508 Lines: 58 --==_Exmh_1261110557_3855P Content-Type: text/plain; charset=us-ascii On Thu, 17 Dec 2009 18:29:25 EST, Mikulas Patocka said: > There is no need to make a script for it. The script isn't so smart to > tell what is understandable and what is nto. Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non- continuation line, it's probably in its rights to whinge. grep -r -P '^\t{7}(?!(.*,$|.*\);$))' . | more produces a whole lot of "this can't end well" output. My favorite so far: fs/reisersfs/do_balan.c, lines 460-477 (note: 3 leading tabs elided) leaf_paste_entries(&bi, n + item_pos - ret_val, l_pos_in_item, 1, (struct reiserfs_de_head *) body, body + DEH_SIZE, tb-> insert_size [0] ); Yes, that used to be 24 more columns to the right. Gaak. --==_Exmh_1261110557_3855P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Exmh version 2.5 07/13/2001 iD8DBQFLKwUdcC3lWbTT17ARAneDAKCbUY9j6dpFbsi7TTin/t1rd0B2OgCgyRV2 elcRq2QVY9OQCTNq0p0lEpU= =JH5A -----END PGP SIGNATURE----- --==_Exmh_1261110557_3855P-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/