Date: Fri, 18 Dec 2009 06:23:44 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Jason Garrett-Glaser <darkshikari@gmail.com>
Cc: Kasper Sandberg <lkml@metanurb.dk>, Mike Galbraith <efault@gmx.de>,
       Peter Zijlstra <a.p.zijlstra@chello.nl>,
       LKML Mailinglist <linux-kernel@vger.kernel.org>,
       Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: x264 benchmarks BFS vs CFS
Message-ID: <20091218052344.GD417@elte.hu>
References: <1261042383.14314.0.camel@localhost>
 <28f2fcbc0912170242r6d93dfb1j337558a829e21a75@mail.gmail.com>
 <20091217105316.GB26010@elte.hu>
 <1261047618.14314.6.camel@localhost>
 <28f2fcbc0912171718x271520b4k5da3376b5182d88a@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <28f2fcbc0912171718x271520b4k5da3376b5182d88a@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2125
Lines: 50


* Jason Garrett-Glaser <darkshikari@gmail.com> wrote:

> On Thu, Dec 17, 2009 at 3:00 AM, Kasper Sandberg <lkml@metanurb.dk> wrote:
> > On Thu, 2009-12-17 at 11:53 +0100, Ingo Molnar wrote:
> >> * Jason Garrett-Glaser <darkshikari@gmail.com> wrote:
> >>
> >> > On Thu, Dec 17, 2009 at 1:33 AM, Kasper Sandberg <lkml@metanurb.dk> wrote:
> >> > > well well :) nothing quite speaks out like graphs..
> >> > >
> >> > > http://doom10.org/index.php?topic=78.0
> >> > >
> >> > >
> >> > >
> >> > > regards,
> >> > > Kasper Sandberg
> >> >
> >> > Yeah, I sent this to Mike a bit ago. ?Seems that .32 has basically tied
> >> > it--and given the strict thread-ordering expectations of x264, you basically
> >> > can't expect it to do any better, though I'm curious what's responsible for
> >> > the gap in "veryslow", even with SCHED_BATCH enabled.
> >> >
> >> > The most odd case is that of "ultrafast", in which CFS immediately ties BFS
> >> > when we enable SCHED_BATCH. ?We're doing some further testing to see exactly
> >
> > Thats kinda besides the point.
> >
> > all these tunables and weirdness is _NEVER_ going to work for people.
> 
> Can't individually applications request SCHED_BATCH?  Our plan was to have 
> x264 simply detect if it was necessary (once we figure out what encoding 
> settings result in the large gap situation) and automatically enable it for 
> the current application.

Yeah, SCHED_BATCH can be requested at will by an app. It's an unprivileged 
operation. It gets passed down to child tasks. (You can just do it 
unconditionally - older kernels will ignore it and give you an error code for 
setscheduler call.)

Having said that, we generally try to make things perform well without apps 
having to switch themselves to SCHED_BATCH. Mike, do you think we can make 
x264 perform as well (or nearly as well) under SCHED_OTHER as under 
SCHED_BATCH?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/