Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165AbZLRKP1 (ORCPT ); Fri, 18 Dec 2009 05:15:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751738AbZLRKPZ (ORCPT ); Fri, 18 Dec 2009 05:15:25 -0500 Received: from cantor2.suse.de ([195.135.220.15]:47463 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbZLRKPY (ORCPT ); Fri, 18 Dec 2009 05:15:24 -0500 Date: Fri, 18 Dec 2009 11:15:21 +0100 Message-ID: From: Takashi Iwai To: Xiaotian Feng Cc: Amerigo Wang , linux-kernel@vger.kernel.org, Henrique de Moraes Holschuh , Corentin Chary , ibm-acpi-devel@lists.sourceforge.net, Len Brown , Alan Jenkins , akpm@linux-foundation.org, helight.xu@gmail.com Subject: Re: [Patch] thinkpad_acpi: fix a build error In-Reply-To: <7b6bb4a50912180142u5e66fa88odb7cd3b6fa1a2ba2@mail.gmail.com> References: <20091218093132.4415.23424.sendpatchset@localhost.localdomain> <7b6bb4a50912180142u5e66fa88odb7cd3b6fa1a2ba2@mail.gmail.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2116 Lines: 57 At Fri, 18 Dec 2009 17:42:34 +0800, Xiaotian Feng wrote: > > Ingo already sent this patch yesterday. > http://lkml.org/lkml/2009/12/17/25 > > > On Fri, Dec 18, 2009 at 5:28 PM, Amerigo Wang wrote: > > > > This patch fixes the following build error: > > > >  Building modules, stage 2. > >  MODPOST 1834 modules > > ERROR: "snd_card_create" [drivers/platform/x86/thinkpad_acpi.ko] undefined! > > ERROR: "snd_ctl_notify" [drivers/platform/x86/thinkpad_acpi.ko] undefined! > > ERROR: "snd_ctl_boolean_mono_info" [drivers/platform/x86/thinkpad_acpi.ko] undefined! > > ERROR: "snd_ctl_new1" [drivers/platform/x86/thinkpad_acpi.ko] undefined! > > ERROR: "snd_card_free" [drivers/platform/x86/thinkpad_acpi.ko] undefined! > > ERROR: "snd_card_register" [drivers/platform/x86/thinkpad_acpi.ko] undefined! > > ERROR: "snd_ctl_add" [drivers/platform/x86/thinkpad_acpi.ko] undefined! > > > > Cc: Len Brown > > Cc: Corentin Chary > > Cc: Henrique de Moraes Holschuh > > Cc: Alan Jenkins > > Reported-by: Helight.Xu > > Signed-off-by: WANG Cong > > Tested-by: Helight.Xu > > > > --- > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > > index fc5bf9d..596966c 100644 > > --- a/drivers/platform/x86/Kconfig > > +++ b/drivers/platform/x86/Kconfig > > @@ -215,6 +215,7 @@ config THINKPAD_ACPI > >        depends on ACPI > >        depends on INPUT > >        depends on RFKILL || RFKILL = n > > +       depends on SOUND The patch isn't correct (I guess the upstream fix is same?). CONFIG_SOUND is a global config for sound subsystem. The relevant functions are ALSA core part, which is CONFIG_SND. So, the fix should be: depends on SND instead. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/