Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754128AbZLRO23 (ORCPT ); Fri, 18 Dec 2009 09:28:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753996AbZLRO2R (ORCPT ); Fri, 18 Dec 2009 09:28:17 -0500 Received: from khc.piap.pl ([195.187.100.11]:34796 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753978AbZLRO2P (ORCPT ); Fri, 18 Dec 2009 09:28:15 -0500 From: Krzysztof Halasa To: Valdis.Kletnieks@vt.edu Cc: Mikulas Patocka , Paul Mundt , linux-kernel@vger.kernel.org, Linus Torvalds , Alasdair G Kergon , dm-devel@redhat.com Subject: Re: [PATCH] Drop 80-character limit in checkpatch.pl References: <20091217061229.GD3946@linux-sh.org> <24653.1261110557@localhost> Date: Fri, 18 Dec 2009 15:28:12 +0100 In-Reply-To: <24653.1261110557@localhost> (Valdis Kletnieks's message of "Thu, 17 Dec 2009 23:29:17 -0500") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 41 Valdis.Kletnieks@vt.edu writes: > Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non- > continuation line, it's probably in its rights to whinge. Yes, but don't make it a hard error, only a suggestion that something is probably really wrong. > fs/reisersfs/do_balan.c, lines 460-477 (note: 3 leading tabs elided) > > leaf_paste_entries(&bi, > n + > item_pos > - > ret_val, > l_pos_in_item, > 1, > (struct > reiserfs_de_head > *) > body, > body > + > DEH_SIZE, > tb-> > insert_size > [0] > ); > > Yes, that used to be 24 more columns to the right. Gaak. Precisely. It's a clear show of the damage hard rules like that do. I can't even tell how the code should be fixed and if the simple merging would do, since I can't really imagine how it would look like :-) -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/