Date: Fri, 18 Dec 2009 15:31:34 +0100
Message-ID: <s5h4ono73qx.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Xiaotian Feng <xtfeng@gmail.com>, Amerigo Wang <amwang@redhat.com>,
       linux-kernel@vger.kernel.org, Corentin Chary <corentincj@iksaif.net>,
       ibm-acpi-devel@lists.sourceforge.net, Len Brown <len.brown@intel.com>,
       Alan Jenkins <alan-jenkins@tuffmail.co.uk>, akpm@linux-foundation.org,
       helight.xu@gmail.com
Subject: Re: [Patch] thinkpad_acpi: fix a build error
In-Reply-To: <20091218142815.GB15898@khazad-dum.debian.net>
References: <20091218093132.4415.23424.sendpatchset@localhost.localdomain>
	<7b6bb4a50912180142u5e66fa88odb7cd3b6fa1a2ba2@mail.gmail.com>
	<s5hhbrowpty.wl%tiwai@suse.de>
	<20091218142815.GB15898@khazad-dum.debian.net>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 807
Lines: 29

At Fri, 18 Dec 2009 12:28:15 -0200,
Henrique de Moraes Holschuh wrote:
> 
> On Fri, 18 Dec 2009, Takashi Iwai wrote:
> > The patch isn't correct (I guess the upstream fix is same?).
> > 
> > CONFIG_SOUND is a global config for sound subsystem.  The relevant
> > functions are ALSA core part, which is CONFIG_SND.
> > So, the fix should be:
> > 
> > 	depends on SND
> > 
> > instead.
> 
> Indeed.  Ingo already fixed that too.
> 
> Although I personally would prefer:
> select SOUND
> select SND

SND already depends on SOUND, so it's just superfluous.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/