Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754352AbZLRPKP (ORCPT ); Fri, 18 Dec 2009 10:10:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754159AbZLRPKN (ORCPT ); Fri, 18 Dec 2009 10:10:13 -0500 Received: from cantor.suse.de ([195.135.220.2]:59175 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753800AbZLRPKL (ORCPT ); Fri, 18 Dec 2009 10:10:11 -0500 Date: Fri, 18 Dec 2009 16:10:08 +0100 Message-ID: From: Takashi Iwai To: Henrique de Moraes Holschuh Cc: Xiaotian Feng , Amerigo Wang , linux-kernel@vger.kernel.org, Corentin Chary , ibm-acpi-devel@lists.sourceforge.net, Len Brown , Alan Jenkins , akpm@linux-foundation.org, helight.xu@gmail.com Subject: Re: [Patch] thinkpad_acpi: fix a build error In-Reply-To: <20091218150324.GA5383@khazad-dum.debian.net> References: <20091218093132.4415.23424.sendpatchset@localhost.localdomain> <7b6bb4a50912180142u5e66fa88odb7cd3b6fa1a2ba2@mail.gmail.com> <20091218142815.GB15898@khazad-dum.debian.net> <20091218150324.GA5383@khazad-dum.debian.net> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1171 Lines: 37 At Fri, 18 Dec 2009 13:03:24 -0200, Henrique de Moraes Holschuh wrote: > > On Fri, 18 Dec 2009, Takashi Iwai wrote: > > At Fri, 18 Dec 2009 12:28:15 -0200, > > Henrique de Moraes Holschuh wrote: > > > On Fri, 18 Dec 2009, Takashi Iwai wrote: > > > > The patch isn't correct (I guess the upstream fix is same?). > > > > > > > > CONFIG_SOUND is a global config for sound subsystem. The relevant > > > > functions are ALSA core part, which is CONFIG_SND. > > > > So, the fix should be: > > > > > > > > depends on SND > > > > > > > > instead. > > > > > > Indeed. Ingo already fixed that too. > > > > > > Although I personally would prefer: > > > select SOUND > > > select SND > > > > SND already depends on SOUND, so it's just superfluous. > > No, it is not (test it). Which is the main reason why select can be a pain. Ah, OK, it's "select". Yeah it's a real pain, and should be avoided in such a case... Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/