Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754465AbZLRPNU (ORCPT ); Fri, 18 Dec 2009 10:13:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754279AbZLRPNT (ORCPT ); Fri, 18 Dec 2009 10:13:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40504 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754244AbZLRPNS (ORCPT ); Fri, 18 Dec 2009 10:13:18 -0500 Date: Fri, 18 Dec 2009 15:12:41 +0000 From: Alasdair G Kergon To: device-mapper development , Joe Perches , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, Paul Mundt , Mikulas Patocka , Andy Whitcroft , Andrew Morton , Linus Torvalds Subject: Re: [dm-devel] Re: [PATCH] scripts/checkpatch.pl: Change long line warning to 105 chars Message-ID: <20091218151241.GD9334@agk-dp.fab.redhat.com> Mail-Followup-To: device-mapper development , Joe Perches , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, Paul Mundt , Mikulas Patocka , Andy Whitcroft , Andrew Morton , Linus Torvalds References: <20091217061229.GD3946@linux-sh.org> <24653.1261110557@localhost> <1261113144.13734.317.camel@Joe-Laptop.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Red Hat UK Ltd. Registered in England and Wales, number 03798903. Registered Office: Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE. User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 23 On Fri, Dec 18, 2009 at 03:37:00PM +0100, Krzysztof Halasa wrote: > Not sure if that's long enough (maybe it is). > 132 looks like the next "natural" number. Well it's good that this thread has produced more examples where it's reasonable and acceptable to exceed 80 characters. What do people feel about files where the policy is to place all the parameters passed into a function on the same line, regardless of its consequent length? (What kicked this all off was a patch Mikulas submitted containing many long lines, one of which hits column 264. Personally, I dislike reading code with lines that wrap, but using a 132-column terminal width is fine.) Alasdair -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/