Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754495AbZLRPW1 (ORCPT ); Fri, 18 Dec 2009 10:22:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753804AbZLRPW0 (ORCPT ); Fri, 18 Dec 2009 10:22:26 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:42670 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753608AbZLRPWZ (ORCPT ); Fri, 18 Dec 2009 10:22:25 -0500 Date: Fri, 18 Dec 2009 07:22:02 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Mark Hounschell cc: Alain Knaff , Mark Hounschell , linux-kernel@vger.kernel.org, fdutils@fdutils.linux.lu Subject: Re: [Fdutils] DMA cache consistency bug introduced in 2.6.28 (Was: Re: Cannot format floppies under kernel 2.6.*?) In-Reply-To: <4B2B5F86.1090403@cfl.rr.com> Message-ID: References: <4AFB3962.2020106@ntlworld.com> <4B27983F.5090600@compro.net> <4B27EF18.7050101@knaff.lu> <4B28FDEB.3030800@compro.net> <4B290029.90602@knaff.lu> <4B2901DB.8040403@compro.net> <4B29052B.9070406@knaff.lu> <4B292D84.5040306@compro.net> <4B29624F.2080109@knaff.lu> <4B2A3805.8040707@compro.net> <4B2A3E3E.8060405@knaff.lu> <4B2A4975.8020809@compro.net> <4B2A49F4.6070402@compro.net> <4B2A4B86.8060307@knaff.lu> <4B2A4C78.10107@compro.net> <4B2A4CF7.6040000@knaff.lu> <4B2A4EC9.2030902@compro.net> <4B2A4FA5.5000701@knaff.lu> <4B2A5192.6090602@compro.net> <4B2A530D.3080606@knaff! .lu> <4B2A6394.3080705@knaff.lu> <4B2A98BB.5080406@knaff.lu> <4B2AAC87.5000703@knaff.lu> <4B2ABDC8.6090104@knaff.lu> <4B2B4485.6000305@cfl.rr.com> <4B2B5F86.1090403@cfl.rr.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 38 On Fri, 18 Dec 2009, Mark Hounschell wrote: > > This one doesn't build: > > CC [M] fs/ext3/super.o > fs/ext3/super.c: In function ?ext3_quota_on?: > fs/ext3/super.c:2839: error: ?nd? undeclared (first use in this function) > fs/ext3/super.c:2839: error: (Each undeclared identifier is reported only once > fs/ext3/super.c:2839: error: for each function it appears in.) > make[2]: *** [fs/ext3/super.o] Error 1 > make[1]: *** [fs/ext3] Error 2 > make: *** [fs] Error 2 > > I haven't yet determined that I can but, if I were to make a modification to the > tree now to fix this would that screw up the bisect process? You can safely fix unrelated problems without screwing up the bisection. And in this case you can be pretty sure that this is unrelated, so it's all ok. The fix for that silly problem is - path_put(&nd.path); + path_put(&path); (it's due to a silent merge failure - it merged cleanly, but semantics had changed in a branch and impacted code that was newly introduced in another branch). Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/