Date: Fri, 18 Dec 2009 08:58:58 -0800
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Alasdair G Kergon <agk@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
       Joe Perches <joe@perches.com>, Valdis.Kletnieks@vt.edu,
       linux-kernel@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>,
       Mikulas Patocka <mpatocka@redhat.com>,
       Andy Whitcroft <apw@canonical.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [dm-devel] Re: [PATCH] scripts/checkpatch.pl: Change long line
 warning to 105 chars
Message-Id: <20091218085858.029c5660.randy.dunlap@oracle.com>
In-Reply-To: <20091218151241.GD9334@agk-dp.fab.redhat.com>
References: <Pine.LNX.4.64.0912151656010.29183@hs20-bc2-1.build.redhat.com>
	<20091217061229.GD3946@linux-sh.org>
	<m3tyvqgfs4.fsf@intrepid.localdomain>
	<Pine.LNX.4.64.0912171744070.21142@hs20-bc2-1.build.redhat.com>
	<24653.1261110557@localhost>
	<1261113144.13734.317.camel@Joe-Laptop.home>
	<m3iqc41h83.fsf@intrepid.localdomain>
	<20091218151241.GD9334@agk-dp.fab.redhat.com>
Organization: Oracle Linux Eng.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1184
Lines: 31

On Fri, 18 Dec 2009 15:12:41 +0000 Alasdair G Kergon wrote:

> On Fri, Dec 18, 2009 at 03:37:00PM +0100, Krzysztof Halasa wrote:
> > Not sure if that's long enough (maybe it is).
> > 132 looks like the next "natural" number.
> 
> Well it's good that this thread has produced more examples where it's
> reasonable and acceptable to exceed 80 characters.
> 
> What do people feel about files where the policy is to place all the
> parameters passed into a function on the same line, regardless of its
> consequent length?  

Not good IMO.  It's much easier to read something that is restricted in
width than to have to scroll/pan side to side.
(e.g., newspaper columns.  Oops, what's a newspaper?)


> (What kicked this all off was a patch Mikulas submitted containing many
> long lines, one of which hits column 264.  Personally, I dislike reading
> code with lines that wrap, but using a 132-column terminal width is
> fine.)


---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/