Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755046AbZLRRKN (ORCPT ); Fri, 18 Dec 2009 12:10:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754990AbZLRRKL (ORCPT ); Fri, 18 Dec 2009 12:10:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4045 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754992AbZLRRKI (ORCPT ); Fri, 18 Dec 2009 12:10:08 -0500 Date: Fri, 18 Dec 2009 12:09:28 -0500 (EST) From: Mikulas Patocka X-X-Sender: mpatocka@hs20-bc2-1.build.redhat.com To: Linus Torvalds cc: kevin granade , Krzysztof Halasa , Valdis.Kletnieks@vt.edu, Paul Mundt , linux-kernel@vger.kernel.org, Alasdair G Kergon , dm-devel@redhat.com Subject: Re: [PATCH] Drop 80-character limit in checkpatch.pl In-Reply-To: Message-ID: References: <20091217061229.GD3946@linux-sh.org> <24653.1261110557@localhost> <7004b08e0912180652p42777da3h70906f2fbdb60a69@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1622 Lines: 38 On Fri, 18 Dec 2009, Linus Torvalds wrote: > On Fri, 18 Dec 2009, Mikulas Patocka wrote: > > > > But think what happens when someone views that 100-char code on 80-char > > terminal (or for example 94-char, that I used for some times too) --- > > every second line will be wasted with just 20 characters on the left. > > What kind of CRAZY crap argument is that? > > The current rule is 80 characters - but how many lines are actually even > close to 80 characters long? Very few. > > So that "every second line" statement is pure and utter idiocy. Instead, > what you get is totally the reverse: instead of wasting two lines _anyway_ > due to a hard-newline, you often get a single line instead (since most of > us don't work in 24x80 windows to begin with). > > Linus Function declarations are often larger than 80 characters. And if you wrap them at 100, you are wasting every second line on 80-character display. If you make line length unlimited, the space will be used optimally on all displays --- a function with 200 character declaration will use 3 lines on 80-character display and 2 lines on 100-character display. And besides --- wrapping at 100 doesn't fix the initial problem (why I posted this thread) --- that making any modification to the function header or long expression requires the user to manually realign the arguments. Mikulas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/