Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932159AbZLRRKo (ORCPT ); Fri, 18 Dec 2009 12:10:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755082AbZLRRKm (ORCPT ); Fri, 18 Dec 2009 12:10:42 -0500 Received: from mail-pw0-f42.google.com ([209.85.160.42]:54369 "EHLO mail-pw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755058AbZLRRKl convert rfc822-to-8bit (ORCPT ); Fri, 18 Dec 2009 12:10:41 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=gsDIK25nHqgMEDxhq3M/kaXpcR0sevMUtmN9ypthcWyjcT2GvxrmTDv+46UgLfkDbc vp85pqbQ4p7WrG5Hur8D7TQ+2A0T+zL79umBzZJHpj6H/q9cdYQ9gzONYKKFWgdiKjVc 9/eKZYtYy/owZ5reoe0Fe1r1kbrusmFF24ztY= MIME-Version: 1.0 In-Reply-To: <20091217110556.0b103125@jbarnes-piketon> References: <4B1A6F78.8010408@myrealbox.com> <50CA8D92EC%linux@youmustbejoking.demon.co.uk> <20091206173222.4c2d5aaa@jbarnes-piketon> <20091210095422.3c5a75d1@jbarnes-piketon> <20091217110556.0b103125@jbarnes-piketon> Date: Sat, 19 Dec 2009 00:10:39 +0700 Message-ID: Subject: Re: 2.6.31 -> 2.6.32 Sound and video regressions From: Emmanuel Benisty To: Jesse Barnes Cc: Darren Salt , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, luto@myrealbox.com, eric@anholt.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4030 Lines: 97 On Fri, Dec 18, 2009 at 2:05 AM, Jesse Barnes wrote: > On Thu, 10 Dec 2009 09:54:22 -0800 > Jesse Barnes wrote: > >> On Tue, 8 Dec 2009 20:20:07 +0700 >> Emmanuel Benisty wrote: >> >> > On Mon, Dec 7, 2009 at 8:38 PM, Emmanuel Benisty >> > wrote: >> > > On Mon, Dec 7, 2009 at 10:52 AM, Emmanuel Benisty >> > > wrote: >> > >> On Mon, Dec 7, 2009 at 8:32 AM, Jesse Barnes >> > >> wrote: >> > >>> On Sat, 05 Dec 2009 23:44:55 +0000 >> > >>> Darren Salt wrote: >> > >>> >> > >>>> I demand that Andy Lutomirski may or may not have written... >> > >>>> >> > >>>> > Emmanuel Benisty wrote: >> > >>>> [snip] >> > >>>> >> I just wanted to report 2 regressions I am having now with >> > >>>> >> 2.6.32. Video >> > >>>> >> Screen is flickering/glitching like crazy in X. It happens >> > >>>> >> whether randomly or when conky is refreshed, when the mouse >> > >>>> >> cursor moves and like hell when a page is loading in the >> > >>>> >> browser. Not so easy to describe this issue. >> > >>>> [snip] >> > >>>> >> > >>>> > That sounds like FIFO underruns, which (I think) were >> > >>>> > introduced when self-refresh was enabled but should have been >> > >>>> > fixed. I personally have no clue how to fix them, but if you >> > >>>> > told the Intel people what kind of chip you have (lspci >> > >>>> > output), they can probably fix it. >> > >>>> >> > >>>> It also sounds like what I'm seeing on my EeePC 901. It only >> > >>>> happens after resume, which makes STR a little less than >> > >>>> useful; the display will, sooner or later, show a single >> > >>>> colour (which is, presumably, the result of a display engine >> > >>>> hang, as described in the comment immediately before >> > >>>> intel_calculate_wm) and, seemingly, be stuck like that until >> > >>>> power-off or reboot. >> > >>>> >> > >>>> Whether it *is* the same problem, I couldn't say. >> > >>>> >> > >>>> Needless to say, this problem goes away if I disable KMS. >> > >>> >> > >>> Arg, there are a few reports of this now, but I haven't been >> > >>> able to reproduce it.  I'll try harder...  (FYI the upstream >> > >>> bugs.freedesktop.org # for it is 24314). >> > >> >> > >> It *seems* that we are facing two different issues here (I don't >> > >> even use S2R and the problem is there since the very first second >> > >> I start X). Anyway, I have bisected the problem on my box, it >> > >> turns out to be this one: >> > >> >> > >> drm/i915: Fix render reclock availability detection >> > >> >> > >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=181a5336d6cc836f05507410d66988c483ad0154 >> > >> >> > > So, I have reverted this commit and rebuilt 2.6.32. It completely >> > > solved the issue described in my first post. >> > > >> > >> > just FTR, it looks like I'm not alone: >> > http://forums.gentoo.org/viewtopic-p-6087556.html#6087556 >> >> Great, thanks for narrowing it down.  I'll see if I can come up with a >> fix. > > Can you give this a try? > > -- > Jesse Barnes, Intel Open Source Technology Center > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_d > index 279dc96..5bde801 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -3808,6 +3808,8 @@ void intel_decrease_renderclock(struct drm_device *dev) >  { >        drm_i915_private_t *dev_priv = dev->dev_private; > > +       return; > + >        if (IS_IRONLAKE(dev)) >                return; > > Thanks a lot Jesse, I have tried your bugzilla patch. Anyone interested, it's here: http://bugzilla.kernel.org/show_bug.cgi?id=14781 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/