Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932229AbZLRRMt (ORCPT ); Fri, 18 Dec 2009 12:12:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932195AbZLRRMr (ORCPT ); Fri, 18 Dec 2009 12:12:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21991 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755037AbZLRRMp (ORCPT ); Fri, 18 Dec 2009 12:12:45 -0500 Date: Fri, 18 Dec 2009 12:12:34 -0500 (EST) From: Mikulas Patocka X-X-Sender: mpatocka@hs20-bc2-1.build.redhat.com To: Randy Dunlap cc: Alasdair G Kergon , device-mapper development , Joe Perches , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, Paul Mundt , Andy Whitcroft , Andrew Morton , Linus Torvalds Subject: Re: [dm-devel] Re: [PATCH] scripts/checkpatch.pl: Change long line warning to 105 chars In-Reply-To: <20091218085858.029c5660.randy.dunlap@oracle.com> Message-ID: References: <20091217061229.GD3946@linux-sh.org> <24653.1261110557@localhost> <1261113144.13734.317.camel@Joe-Laptop.home> <20091218151241.GD9334@agk-dp.fab.redhat.com> <20091218085858.029c5660.randy.dunlap@oracle.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 31 On Fri, 18 Dec 2009, Randy Dunlap wrote: > On Fri, 18 Dec 2009 15:12:41 +0000 Alasdair G Kergon wrote: > > > On Fri, Dec 18, 2009 at 03:37:00PM +0100, Krzysztof Halasa wrote: > > > Not sure if that's long enough (maybe it is). > > > 132 looks like the next "natural" number. > > > > Well it's good that this thread has produced more examples where it's > > reasonable and acceptable to exceed 80 characters. > > > > What do people feel about files where the policy is to place all the > > parameters passed into a function on the same line, regardless of its > > consequent length? > > Not good IMO. It's much easier to read something that is restricted in > width than to have to scroll/pan side to side. > (e.g., newspaper columns. Oops, what's a newspaper?) I don't like scrolling too but most viewers and editors wrap it automatically to screen width. For example, restrict your terminal to 50 columnts and try using "less". Mikulas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/