Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932318AbZLRRox (ORCPT ); Fri, 18 Dec 2009 12:44:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755097AbZLRRow (ORCPT ); Fri, 18 Dec 2009 12:44:52 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:34439 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754482AbZLRRov (ORCPT ); Fri, 18 Dec 2009 12:44:51 -0500 Date: Fri, 18 Dec 2009 09:43:49 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Paul Mundt cc: Joe Perches , Valdis.Kletnieks@vt.edu, Andy Whitcroft , Andrew Morton , Mikulas Patocka , Krzysztof Halasa , linux-kernel@vger.kernel.org, Alasdair G Kergon , dm-devel@redhat.com Subject: Re: [PATCH] scripts/checkpatch.pl: Change long line warning to 105 chars In-Reply-To: <20091218055712.GA4186@linux-sh.org> Message-ID: References: <20091217061229.GD3946@linux-sh.org> <24653.1261110557@localhost> <1261113144.13734.317.camel@Joe-Laptop.home> <20091218055712.GA4186@linux-sh.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1091 Lines: 28 On Fri, 18 Dec 2009, Paul Mundt wrote: > On Thu, Dec 17, 2009 at 09:12:24PM -0800, Joe Perches wrote: > > On Thu, 2009-12-17 at 23:29 -0500, Valdis.Kletnieks@vt.edu wrote: > > > Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non- > > > continuation line, it's probably in its rights to whinge. > > > grep -r -P '^\t{7:}(?!(.*,$|.*\);$))' . | more > > > produces a whole lot of "this can't end well" output. > > > > I think this is a good test to add to checkpatch. > > > > Add 105 character long line WARN test > > Add 80 character long line STRICT test > > Add 6+ leading indent tabs test, consider restructuring > > > This looks like a reasonable compromise. I like this. Except I think the indent test should count spaces too some way. Or do we already warn about excessive space that should be tabs? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/