Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755275AbZLRRyr (ORCPT ); Fri, 18 Dec 2009 12:54:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753884AbZLRRyq (ORCPT ); Fri, 18 Dec 2009 12:54:46 -0500 Received: from mail.perches.com ([173.55.12.10]:1288 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752863AbZLRRyp (ORCPT ); Fri, 18 Dec 2009 12:54:45 -0500 Subject: Re: [PATCH] scripts/checkpatch.pl: Change long line warning to 105 chars From: Joe Perches To: Linus Torvalds Cc: Paul Mundt , Valdis.Kletnieks@vt.edu, Andy Whitcroft , Andrew Morton , Mikulas Patocka , Krzysztof Halasa , linux-kernel@vger.kernel.org, Alasdair G Kergon , dm-devel@redhat.com In-Reply-To: References: <20091217061229.GD3946@linux-sh.org> <24653.1261110557@localhost> <1261113144.13734.317.camel@Joe-Laptop.home> <20091218055712.GA4186@linux-sh.org> Content-Type: text/plain; charset="UTF-8" Date: Fri, 18 Dec 2009 09:54:44 -0800 Message-ID: <1261158884.24328.37.camel@Joe-Laptop.home> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 764 Lines: 20 On Fri, 2009-12-18 at 09:43 -0800, Linus Torvalds wrote: > I like this. Except I think the indent test should count spaces too some > way. Or do we already warn about excessive space that should be tabs? Andy's the checkpatch guy to verify this but: There's a separate test for spaces that should be tabs. If you had a 64 space indent and ran the silly script, it'd complain about the spaces. If you converted the spaces to tabs and ran the silly script again with --strict, it'd complain about the indent depth. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/