Date: Fri, 18 Dec 2009 10:41:46 -0800
From: Greg KH <greg@kroah.com>
To: Justin Madru <jdm64@gawab.com>
Cc: linux-kernel@vger.kernel.org, gregkh@suse.de, error27@gmail.com,
       ray-lk@madrabbit.org
Subject: Re: [PATCH] staging: s5k3e2fx.c: simplify complexity by factoring
Message-ID: <20091218184146.GE2909@kroah.com>
References: <1260910330-3409-1-git-send-email-jdm64@gawab.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1260910330-3409-1-git-send-email-jdm64@gawab.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1064
Lines: 30

On Tue, Dec 15, 2009 at 12:52:10PM -0800, Justin Madru wrote:
> the code was looping, seting s_move[i] to the following calculations
> 
> if (actual_step >= 0)
>         s_move[i] = ((((i + 1) * gain + 0x200) - (i * gain + 0x200)) / 0x400);
> else
>         s_move[i] = ((((i + 1) * gain - 0x200) - (i * gain - 0x200)) / 0x400);
> 
> but, this code redues to the expression
> 	s_move[i] = gain >> 10;
> 
> The reason for the complexity was to generate a step function with
> integer division and rounding to land on specific values. But these calculations
> can be simplified to the following code:
> 
> 	gain = ((actual_step << 10) / 5) >> 10;
> 	for (i = 0; i <= 4; i++)
> 		s_move[i] = gain;

Care to resend this with a Signed-off-by: line, and add the reviewed-by
line that was requested by Ray?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/