Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932292AbZLRSl7 (ORCPT ); Fri, 18 Dec 2009 13:41:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753592AbZLRSl6 (ORCPT ); Fri, 18 Dec 2009 13:41:58 -0500 Received: from one.firstfloor.org ([213.235.205.2]:49764 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752206AbZLRSl5 (ORCPT ); Fri, 18 Dec 2009 13:41:57 -0500 To: Linus Torvalds Cc: Paul Mundt , Joe Perches , Valdis.Kletnieks@vt.edu, Andy Whitcroft , Andrew Morton , Mikulas Patocka , Krzysztof Halasa , linux-kernel@vger.kernel.org, Alasdair G Kergon , dm-devel@redhat.com Subject: Re: [PATCH] scripts/checkpatch.pl: Change long line warning to 105 chars From: Andi Kleen References: <20091217061229.GD3946@linux-sh.org> <24653.1261110557@localhost> <1261113144.13734.317.camel@Joe-Laptop.home> <20091218055712.GA4186@linux-sh.org> Date: Fri, 18 Dec 2009 19:41:50 +0100 In-Reply-To: (Linus Torvalds's message of "Fri, 18 Dec 2009 09:43:49 -0800 (PST)") Message-ID: <871visuntd.fsf@basil.nowhere.org> User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 21 Linus Torvalds writes: > > I like this. Except I think the indent test should count spaces too some > way. Or do we already warn about excessive space that should be tabs? checkpatch warns about those. (it triggers for me all the time because those happen when you copy patch reject blocks from hand and remove the leading character without removing the space afterwards) -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/