Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756095AbZLSETP (ORCPT ); Fri, 18 Dec 2009 23:19:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756065AbZLSETO (ORCPT ); Fri, 18 Dec 2009 23:19:14 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:36598 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756039AbZLSETN (ORCPT ); Fri, 18 Dec 2009 23:19:13 -0500 Date: Fri, 18 Dec 2009 20:19:14 -0800 (PST) Message-Id: <20091218.201914.102544489.davem@davemloft.net> To: jesse.brandeburg@intel.com Cc: roger.oksanen@cs.helsinki.fi, stern@rowland.harvard.edu, jeffrey.t.kirsher@intel.com, bruce.w.allan@intel.com, peter.p.waskiewicz.jr@intel.com, john.ronciak@intel.com, e1000-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: e100 REGRESSION in 2.6.32 (PATCH v2) From: David Miller In-Reply-To: References: <200912171810.45575.roger.oksanen@cs.helsinki.fi> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1359 Lines: 34 From: "Brandeburg, Jesse" Date: Thu, 17 Dec 2009 09:21:49 -0800 (Pacific Standard Time) > > On Thu, 17 Dec 2009, Roger Oksanen wrote: >> e100: Fix broken cbs accounting due to missing memset. >> >> Alan Stern noticed that e100 caused slab corruption. >> commit 98468efddb101f8a29af974101c17ba513b07be1 changed >> the allocation of cbs to use dma pools that don't return zeroed memory, >> especially the cb->status field used to track which cb to clean, causing >> (the visible) double freeing of skbs and a wrong free cbs count. >> >> Now the cbs are explicitly zeroed at allocation time. >> >> Reported-by: Alan Stern >> Tested-by: Alan Stern >> Signed-off-by: Roger Oksanen > > Change looks reasonable, ACK. Applied, thanks everyone. I'll try to requeue the e100 stuff together into -stable again now that this is resolved. > should we also consider a followon patch to zero memory allocated with > pci_pools? Seems useful. Nah, it's more fun debugging subtle bugs like this one. :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/