Date: Sun, 20 Dec 2009 10:33:05 -0800 (PST)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dominik Brodowski <linux@dominikbrodowski.net>
cc: Bjorn Helgaas <bjorn.helgaas@hp.com>, Yinghai Lu <yhlu.kernel@gmail.com>,
       Jesse Barnes <jbarnes@virtuousgeek.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] resources: fix call to alignf() in allocate_resource()
In-Reply-To: <20091220095001.GA6029@comet.dominikbrodowski.net>
Message-ID: <alpine.LFD.2.00.0912201026570.3712@localhost.localdomain>
References: <20091220095001.GA6029@comet.dominikbrodowski.net>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1517
Lines: 39


On Sun, 20 Dec 2009, Dominik Brodowski wrote:
>
> The second parameter to alignf() in allocate_resource() must
> reflect what new resource is attempted to be allocated, else
> functions like pcibios_align_resource() (at least on x86) or
> pcmcia_align() can't work correctly.
> 
> Commit 1e5ad9679016275d422e36b12a98b0927d76f556 broke this by
> setting the "new" resource until we're about to return success.
> To keep the resource untouched when allocate_resource() fails,
> a "tmp" resource is introduced.

Ack. That was subtle. 

That said, maybe a nicer fix to this would be to actually return 'start' 
from the 'alignf' macro. That "modify the resource inside the alignment 
function" thing was always pretty ugly.

And then we'd pass in 'start' instead of 'size' (I have _no_ idea why we 
pass in 'size' to the alignment function, but whatever).

We'd still need to pass in the 'struct resource', but that would be so 
that it can figure out 'flags' (and 'size' if it really needs it) from it, 
but now it would be for reading only. So we could mark it 'const'.

Comments?

But Dominik's patch is ok too - the problem is not his patch, it's our 
longstanding horrible sh*t-for-brains calling convention (for which you 
can probably blame me - mea culpa).

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/