Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754633AbZLTTOr (ORCPT ); Sun, 20 Dec 2009 14:14:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754582AbZLTTOr (ORCPT ); Sun, 20 Dec 2009 14:14:47 -0500 Received: from mail-ew0-f209.google.com ([209.85.219.209]:41591 "EHLO mail-ew0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754366AbZLTTOq (ORCPT ); Sun, 20 Dec 2009 14:14:46 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; b=Bb0iRDmR/3tcWmC4JNxbkkYfYxtsZvMh/w9wGOcq9nGy5sv1xr+6Hh9y9aHQUqGp/o CDzOfz1PwyFExdF3IxSdq7GVqgTSa5JtIpzxH/Sw5SnVXY7t+V6mh4QZzBLv+wdZIoDp /x8mwKNHK3Yls/mqxXJxLuvqfyqAXpxv6yD6Y= Date: Sun, 20 Dec 2009 20:14:36 +0100 From: Borislav Petkov To: Torsten Kaiser Cc: Linus Torvalds , Linux Kernel Mailing List , Borislav Petkov Subject: Re: Linux 2.6.33-rc1 Message-ID: <20091220191436.GA3982@liondog.tnic> Mail-Followup-To: Borislav Petkov , Torsten Kaiser , Linus Torvalds , Linux Kernel Mailing List , Borislav Petkov References: <64bb37e0912191154n4a7ea5benbb3da57f1aabdbe6@mail.gmail.com> <64bb37e0912200953j2046a935n2f9ecd2cdfed780f@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <64bb37e0912200953j2046a935n2f9ecd2cdfed780f@mail.gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3544 Lines: 78 On Sun, Dec 20, 2009 at 06:53:24PM +0100, Torsten Kaiser wrote: > On Sat, Dec 19, 2009 at 8:54 PM, Torsten Kaiser > wrote: > > [    5.061998] EDAC MC: Ver: 2.1.0 Dec 18 2009 > > [    5.062186] EDAC amd64_edac:  Ver: 3.3.0 Dec 18 2009 > > [    5.062235] EDAC amd64: ECC is enabled by BIOS. > > [    5.062297] EDAC amd64: ECC is enabled by BIOS. > > [    5.128332] EDAC MC: Rev F or later detected > > [    5.134186] EDAC amd64: amd64_read_mc_registers: error reading F2x190. > > [    5.142290] EDAC amd64: amd64_read_mc_registers: error reading F2x194. > > [    5.150355] EDAC MC: DCT0 chip selects: > > [    5.150357] EDAC MC:  0:   512MB 1:   512MB > > [    5.150358] EDAC MC:  2:     0MB 3:     0MB > > [    5.150361] EDAC MC:  4:     0MB 5:     0MB > > [    5.150362] EDAC MC:  6:     0MB 7:     0MB > > [    5.150519] EDAC MC0: Giving out device to 'amd64_edac' 'RevF': DEV > > 0000:00:18.2 > > [    5.150522] EDAC MC: Rev F or later detected > > [    5.150530] EDAC amd64: amd64_read_mc_registers: error reading F2x190. > > [    5.150532] EDAC amd64: amd64_read_mc_registers: error reading F2x194. > > [    5.150533] EDAC MC: DCT0 chip selects: > > [    5.150535] EDAC MC:  0:   512MB 1:   512MB > > [    5.150536] EDAC MC:  2:     0MB 3:     0MB > > [    5.150537] EDAC MC:  4:     0MB 5:     0MB > > [    5.150539] EDAC MC:  6:     0MB 7:     0MB > > [    5.150664] EDAC MC1: Giving out device to 'amd64_edac' 'RevF': DEV > > 0000:00:19.2 > > [    5.150742] EDAC PCI0: Giving out device to module 'amd64_edac' > > controller 'EDAC PCI > >  controller': DEV '0000:00:18.2' (POLLED) > > > > The system has 4x 1GB RAM sticks (2 on each CPU). What are those DIMMs: single or dual ranked? Can you give me the exact model name? > After reading the code in drivers/edac/amd64_edac.c and the > documentation in the AMD reference doc (#32559, I have Rev. 3.08) the > bug is, that the current code does not try to differentiate between > the 64bit and the 128bit mode. > In the doc the sizes for the 64bit mode in table 10, section 4.5.8.1 > are identical to the table ddr2_dbam in amd64_edac.c. > But for the 128bit mode the table 11 should be used, there the sizes > are doubled. > > The code uses the bit 11 (named F10_WIDTH_128 in amd64_edac.h) of the > lower DRAM configuration register to determine the number of channels > in k8_early_channel_count(), but this is not used in > amd64_debug_display_dimm_sizes() That might be the case, can you enable CONFIG_EDAC_DEBUG and CONFIG_EDAC_DEBUG_VERBOSE and rebuild your kernel, please? Then, send me the _whole_ dmesg output. If the output appears truncated, try enlarging the log buffer size by setting log_buf_len on the kernel command line to something large, i.e. 'log_buf_len=10M'. > > > And there is no line like 'EDAC PCI0' for the DRAM controller of the > > second CPU (19.2). Is that normal? > > amd64_edac_init() calls amd64_init_2nd_stage() for each northbrigde, > but amd64_setup_pci_device() only once. > > But from looking at the code, I can't see if a second device is needed or not. No, its not since it seems like the EDAC PCI code scans all known PCI devices anyways. Thanks. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/