Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751983AbZLUGcx (ORCPT ); Mon, 21 Dec 2009 01:32:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751784AbZLUGcv (ORCPT ); Mon, 21 Dec 2009 01:32:51 -0500 Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190]:42678 "EHLO master.linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751772AbZLUGcv (ORCPT ); Mon, 21 Dec 2009 01:32:51 -0500 Date: Mon, 21 Dec 2009 15:32:38 +0900 From: Paul Mundt To: Jiri Kosina Cc: Bartlomiej Zolnierkiewicz , Linus Torvalds , Am?rico Wang , Mikulas Patocka , linux-kernel@vger.kernel.org, Alasdair G Kergon , dm-devel@redhat.com Subject: Re: [PATCH] Drop 80-character limit in checkpatch.pl Message-ID: <20091221063238.GC15721@linux-sh.org> References: <2375c9f90912170131g3144ca2eydfa067c85f6ced44@mail.gmail.com> <200912171618.32882.bzolnier@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1366 Lines: 42 On Fri, Dec 18, 2009 at 02:04:37PM +0100, Jiri Kosina wrote: > On Thu, 17 Dec 2009, Bartlomiej Zolnierkiewicz wrote: > > > > > I like this patch, this is actually what I wanted to do. > > > > > > I have nothing against a switch, but it had better default to off. > > > > > > The whole 80-char limit is insane. It results in insane "fixes". Just > > > about every time somebody "improves" a patch due to the warning, the > > > result is worse than the original patch. > > > > Examples? :) > > balance_leaf() in fs/reiserfs/do_balan.c > > Example picked totally at random: > > set_le_ih_k_offset(ih, > le_ih_k_offset(ih) + > (tb-> > lbytes << > (is_indirect_le_ih > (ih) ? tb->tb_sb-> > s_blocksize_bits - > UNFM_P_SHIFT : > 0))); > > See how everything is nicely aligned to 80 cols? > > > Generally, don't look at this function after having a good lunch you want > to keep. You have been warned. > This isn't a valid example, as it wasn't written by a human. This is the result of Lindent being run blindly on the file and nothing more. Try again. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/