Message-ID: <4B2FADC5.3020709@zytor.com>
Date: Mon, 21 Dec 2009 09:17:57 -0800
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4
MIME-Version: 1.0
To: Ingo Molnar <mingo@elte.hu>
CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
       Arjan van de Ven <arjan@infradead.org>,
       Ritesh Raj Sarraf <rrs@researchut.com>, linux-kernel@vger.kernel.org,
       Thomas Gleixner <tglx@linutronix.de>
Subject: Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not
 provably correct
References: <0io307-9ti.ln1@news.researchut.com> <20091221180537.089C.A69D9226@jp.fujitsu.com> <20091221091330.GA22867@elte.hu>
In-Reply-To: <20091221091330.GA22867@elte.hu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1217
Lines: 37

On 12/21/2009 01:13 AM, Ingo Molnar wrote:
> 
> * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> 
>>>                  from mm/migrate.c:15:
>>> In function ???copy_from_user???,
>>>     inlined from ???do_pages_stat??? at mm/migrate.c:1009:
>>> /tmp/all-yes-config/2.6.33-rc1/arch/x86/include/asm/uaccess_32.h:213: error: 
>>> call to ???copy_from_user_overflow??? declared with attribute error: 
>>> copy_from_user() buffer size is not provably correct
>>
>> afaik, ingo already queued this fix.
>> please wait (very) few days.
>>
>> thanks.
> 
> hm, the one mm/migrate.c fix we had is already in -rc1:
> 
>  b9255850: mm: Adjust do_pages_stat() so gcc can see copy_from_user() is safe
> 
> I've Cc:-ed more folks.
> 

That *is* the error report that he is describing.  What version of gcc
is he using?  It might be dumber than the one I have.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/