Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752017AbZLVKcu (ORCPT ); Tue, 22 Dec 2009 05:32:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751850AbZLVKct (ORCPT ); Tue, 22 Dec 2009 05:32:49 -0500 Received: from hera.kernel.org ([140.211.167.34]:39546 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677AbZLVKcs (ORCPT ); Tue, 22 Dec 2009 05:32:48 -0500 Message-ID: <4B309FEC.8030406@kernel.org> Date: Tue, 22 Dec 2009 02:31:08 -0800 From: Yinghai Lu User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Ingo Molnar , Shaohua Li , Len Brown CC: "Barnes, Jesse" , Linus Torvalds , Andrew Morton , "linux-acpi@vger.kernel.org" , Linux Kernel Mailing List , "linux-pci@vger.kernel.org" Subject: Re: [git pull request] ACPI and driver patches for 2.6.33.merge References: <86802c440912171728s27dd7108k85a0f1563660c95b@mail.gmail.com> <20091218022112.GA30333@sli10-desk.sh.intel.com> <20091218051457.GB417@elte.hu> <4B309AB9.7030208@kernel.org> In-Reply-To: <4B309AB9.7030208@kernel.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1766 Lines: 50 Yinghai Lu wrote: > Ingo Molnar wrote: >> * Shaohua Li wrote: >> >>> On Fri, Dec 18, 2009 at 09:28:50AM +0800, Yinghai Lu wrote: >>>> On Wed, Dec 16, 2009 at 12:06 PM, Len Brown wrote: >>>>> Hi Linus, >>>>> >>>>> please pull from: >>>>> >>>>> git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git release >>>>> >>>> ;.. >>>>> Shaohua Li (3): >>>>> ? ? ?ACPI: Add a generic API for _OSC -v2 >>>>> ? ? ?ACPI: cleanup pci_root _OSC code. >>>>> ? ? ?ACPI: Add platform-wide _OSC support. >>>> it seems these three patches broke the _OSC on my intel new systems. >>>> >>>> revert them fix the problem with AER and pciehp and etc >>> can you give more details? I just cleaned up the _OSC code for AER and >>> pciehp, no function changes. >> Famous last words ;-) >> >> Yinghai, i suspect Shaohua needs the kind of info you'd need if you tried to >> fix it: acpidump, before/after debug boot log, a description of what goes bad, >> etc. > > the so called clean up, change the ret length checking. > > - if (!output.length) > - return AE_NULL_OBJECT; > - > > + /* return buffer should have the same length as cap buffer */ > + if (context->ret.length != context->cap.length) > + return AE_NULL_OBJECT; > printk said: [ 54.709165] calling aer_service_init+0x0/0x2b @ 1 [ 56.121190] run_acpi_osc: ret length 40 cap length 12 [ 56.124996] aer 0000:00:01.0:pcie02: AER service couldn't init device: _OSC failed YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/