To: Jiri Olsa <jolsa@redhat.com>
Cc: jbaron@redhat.com, mingo@elte.hu, rostedt@goodmis.org, fweisbec@gmail.com,
       linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] dynamic debug - adding ring buffer storage support
From: Andi Kleen <andi@firstfloor.org>
References: <1261481526-17630-1-git-send-email-jolsa@redhat.com>
Date: Tue, 22 Dec 2009 13:06:06 +0100
In-Reply-To: <1261481526-17630-1-git-send-email-jolsa@redhat.com> (Jiri Olsa's message of "Tue, 22 Dec 2009 12:32:06 +0100")
Message-ID: <87ws0fcixd.fsf@basil.nowhere.org>
User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1104
Lines: 33

Jiri Olsa <jolsa@redhat.com> writes:

> Hi,
>
> as I use dynamic debug sometimes, I thought it could be useful having
> the possibility to store the output somewhere else than dmesg.
>
> The attached patch implements support for storing dynamic debug
> messages to the ring buffer.
>
> The dynamic debug allows simple addition of new flags,
> so I added 'r' flag for ring buffer storage.
>
> I used the ring buffer implementation from trace framework.
>
> hopefuly this could be any use for others as well...
> plz let me know what you think,

The basic idea sounds good, but doing it all inline is a horrible 
idea. That will bloat the kernel considerably because all
users have to expand this code.

I would suggest to implement an out of line dyndebug_printk()
which does all of this out of line.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/