DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=QvI8CUmQ3xes2TWcCQWTHUdC/H7XIb18cOc79SykMHYE6FE1WsEayioJ7Ov0wSqNk4
         1/AX7biKQo8skpn29nfVYUyFfwfRmuSaeixRMhpvBUZaMhsmm2nsVYxhYzZK44negmwi
         Xs+5ksBVD11q1Xi1+J44WEwvdqwXKFkLuofcg=
MIME-Version: 1.0
In-Reply-To: <20091222120803.GR18217@ZenIV.linux.org.uk>
References: <4B2F619A.8000407@gmail.com>
	 <20091222120803.GR18217@ZenIV.linux.org.uk>
Date: Tue, 22 Dec 2009 22:31:38 +0800
Message-ID: <b3657a100912220631n4d69ea66x23c1296e1abc468a@mail.gmail.com>
Subject: Re: [PATCHv2 02/12]posix_acl: Add the check items
From: liu weni <qingshenlwy@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: chris.mason@oracle.com, joel.becker@oracle.com, cjb@laptop.org,
       jmorris@namei.org, linux-btrfs@vger.kernel.org,
       linux-kernel@vger.kernel.org, onlyflyer@gmail.com, strongzgy@gmail.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1062
Lines: 41

Hi All:

    I'm sorry for my stupid. I am crazy for fixing this bug.
And make so much mistake.
Maybe I need cool down and think more.

--
Best Regards,
Liuwenyi
2009-12-22


2009/12/22 Al Viro <viro@zeniv.linux.org.uk>:
> On Mon, Dec 21, 2009 at 07:52:58PM +0800, Liuwenyi wrote:
>> @@ -102,12 +102,9 @@ static int btrfs_set_acl(struct btrfs_trans_handle
>> *trans,
>> char *value = NULL;
>> mode_t mode;
>>
>> - if (acl) {
>> - ret = posix_acl_valid(acl);
>> - if (ret < 0)
>> - return ret;
>> - ret = 0;
>> - }
>> + ret = posix_acl_valid(acl);
>> + if (ret < 0)
>> + return ret;
>
> ... and now you can't remove acl from btrfs inode. ?At all.
>
> NAK the entire series. ?You are changing existing user-visible behaviour
> for all filesystems for no reason and at least in this case it's clearly
> wrong change.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/