Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751749AbZLVPKt (ORCPT ); Tue, 22 Dec 2009 10:10:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750801AbZLVPKs (ORCPT ); Tue, 22 Dec 2009 10:10:48 -0500 Received: from cantor.suse.de ([195.135.220.2]:42668 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbZLVPKr (ORCPT ); Tue, 22 Dec 2009 10:10:47 -0500 Date: Tue, 22 Dec 2009 16:10:44 +0100 (CET) From: Jiri Kosina X-X-Sender: jikos@twin.jikos.cz To: Paul Mundt Cc: Bartlomiej Zolnierkiewicz , Linus Torvalds , Am?rico Wang , Mikulas Patocka , linux-kernel@vger.kernel.org, Alasdair G Kergon , dm-devel@redhat.com Subject: Re: [PATCH] Drop 80-character limit in checkpatch.pl In-Reply-To: <20091221063238.GC15721@linux-sh.org> Message-ID: References: <2375c9f90912170131g3144ca2eydfa067c85f6ced44@mail.gmail.com> <200912171618.32882.bzolnier@gmail.com> <20091221063238.GC15721@linux-sh.org> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1189 Lines: 39 On Mon, 21 Dec 2009, Paul Mundt wrote: > > Example picked totally at random: > > > > set_le_ih_k_offset(ih, > > le_ih_k_offset(ih) + > > (tb-> > > lbytes << > > (is_indirect_le_ih > > (ih) ? tb->tb_sb-> > > s_blocksize_bits - > > UNFM_P_SHIFT : > > 0))); > > > > See how everything is nicely aligned to 80 cols? > > > > > > Generally, don't look at this function after having a good lunch you want > > to keep. You have been warned. > > > This isn't a valid example, as it wasn't written by a human. This is the > result of Lindent being run blindly on the file and nothing more. > > Try again. But having hard rule imposed on everyone to stick with 80-char rule makes people to do exactly this kind of things (blindly running indent -l80 and believing that it makes the code more readable because it is CodingStyle-compliant(tm)). -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/