Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751773AbZLWA4n (ORCPT ); Tue, 22 Dec 2009 19:56:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751117AbZLWA4l (ORCPT ); Tue, 22 Dec 2009 19:56:41 -0500 Received: from mga02.intel.com ([134.134.136.20]:49248 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844AbZLWA4k (ORCPT ); Tue, 22 Dec 2009 19:56:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.47,439,1257148800"; d="scan'208";a="478490803" Date: Wed, 23 Dec 2009 08:56:37 +0800 From: Shaohua Li To: Yinghai Lu Cc: Ingo Molnar , Len Brown , "Barnes, Jesse" , Linus Torvalds , Andrew Morton , "linux-acpi@vger.kernel.org" , Linux Kernel Mailing List , "linux-pci@vger.kernel.org" Subject: Re: [git pull request] ACPI and driver patches for 2.6.33.merge Message-ID: <20091223005637.GA16783@sli10-desk.sh.intel.com> References: <86802c440912171728s27dd7108k85a0f1563660c95b@mail.gmail.com> <20091218022112.GA30333@sli10-desk.sh.intel.com> <20091218051457.GB417@elte.hu> <4B309AB9.7030208@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B309AB9.7030208@kernel.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1767 Lines: 48 On Tue, Dec 22, 2009 at 06:08:57PM +0800, Yinghai Lu wrote: > Ingo Molnar wrote: > > * Shaohua Li wrote: > > > >> On Fri, Dec 18, 2009 at 09:28:50AM +0800, Yinghai Lu wrote: > >>> On Wed, Dec 16, 2009 at 12:06 PM, Len Brown wrote: > >>>> Hi Linus, > >>>> > >>>> please pull from: > >>>> > >>>> git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git release > >>>> > >>> ;.. > >>>> Shaohua Li (3): > >>>> ? ? ?ACPI: Add a generic API for _OSC -v2 > >>>> ? ? ?ACPI: cleanup pci_root _OSC code. > >>>> ? ? ?ACPI: Add platform-wide _OSC support. > >>> it seems these three patches broke the _OSC on my intel new systems. > >>> > >>> revert them fix the problem with AER and pciehp and etc > >> can you give more details? I just cleaned up the _OSC code for AER and > >> pciehp, no function changes. > > > > Famous last words ;-) > > > > Yinghai, i suspect Shaohua needs the kind of info you'd need if you tried to > > fix it: acpidump, before/after debug boot log, a description of what goes bad, > > etc. > > the so called clean up, change the ret length checking. > > - if (!output.length) > - return AE_NULL_OBJECT; > - > > + /* return buffer should have the same length as cap buffer */ > + if (context->ret.length != context->cap.length) > + return AE_NULL_OBJECT; Wield BIOS. ACPI spec does mention the return buffer have the same length. Does changing the check back make the issue go away? Thanks, Shaohua -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/