Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752981AbZLWBej (ORCPT ); Tue, 22 Dec 2009 20:34:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751922AbZLWBeh (ORCPT ); Tue, 22 Dec 2009 20:34:37 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:38397 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbZLWBeh (ORCPT ); Tue, 22 Dec 2009 20:34:37 -0500 Date: Tue, 22 Dec 2009 17:34:24 -0800 From: Andrew Morton To: Andi Kleen Cc: "Smith, GeoffX" , "linux-kernel@vger.kernel.org" , Michael Stone Subject: Re: [PATCH] prctl: return MCE process flags through pointer Message-Id: <20091222173424.980d5d33.akpm@linux-foundation.org> In-Reply-To: <87hbricwz8.fsf@basil.nowhere.org> References: <354B2877CF17F44BB3FA44EB4DB0E5470C91CE1829@orsmsx510.amr.corp.intel.com> <87hbricwz8.fsf@basil.nowhere.org> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 26 On Wed, 23 Dec 2009 02:14:51 +0100 Andi Kleen wrote: > "Smith, GeoffX" writes: > > > This patch fixes the semantics of prctl() option PR_MCE_KILL_GET > > to pass the return value through *arg2. > > > > With this change, the option now follows the same conventions as the > > other "get" options added since 2.6.0, and also brings it into > > conformance with the advice in chapter 16 of Documentation/CodingStyle. > > > > This prctl() option was only added within the last month, so there are > > not any production applications to break. This patch applies cleanly > > to mainline and to 2.6.32.2 for backporting. > > It breaks the test suite, the man pages, qemu and one slide deck at least. > Should've got it right the first time. What goes wrong with qemu? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/