Date: Wed, 23 Dec 2009 07:41:31 +0100
Message-ID: <s5hhbrimbtw.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Randy Dunlap <rdunlap@xenotime.net>, Marcel Holtmann <marcel@holtmann.org>,
       Xiaotian Feng <xtfeng@gmail.com>, Amerigo Wang <amwang@redhat.com>,
       linux-kernel@vger.kernel.org, Corentin Chary <corentincj@iksaif.net>,
       ibm-acpi-devel@lists.sourceforge.net, Len Brown <len.brown@intel.com>,
       Alan Jenkins <alan-jenkins@tuffmail.co.uk>, akpm@linux-foundation.org,
       helight.xu@gmail.com
Subject: Re: [Patch] thinkpad_acpi: fix a build error
In-Reply-To: <20091222193858.GB1796@khazad-dum.debian.net>
References: <20091218093132.4415.23424.sendpatchset@localhost.localdomain>
	<7b6bb4a50912180142u5e66fa88odb7cd3b6fa1a2ba2@mail.gmail.com>
	<s5hhbrowpty.wl%tiwai@suse.de>
	<20091218142815.GB15898@khazad-dum.debian.net>
	<1261435136.4041.152.camel@localhost.localdomain>
	<20091221144432.81702725.rdunlap@xenotime.net>
	<20091222193858.GB1796@khazad-dum.debian.net>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1768
Lines: 49

At Tue, 22 Dec 2009 17:38:58 -0200,
Henrique de Moraes Holschuh wrote:
> 
> On Mon, 21 Dec 2009, Randy Dunlap wrote:
> > On Mon, 21 Dec 2009 14:38:56 -0800 Marcel Holtmann wrote:
> > > > > The patch isn't correct (I guess the upstream fix is same?).
> > > > > 
> > > > > CONFIG_SOUND is a global config for sound subsystem.  The relevant
> > > > > functions are ALSA core part, which is CONFIG_SND.
> > > > > So, the fix should be:
> > > > > 
> > > > > 	depends on SND
> > > > > 
> > > > > instead.
> > > > 
> > > > Indeed.  Ingo already fixed that too.
> > > > 
> > > > Although I personally would prefer:
> > > > select SOUND
> > > > select SND
> > > > 
> > > > But anything that stops the build errors will do for now.
> > > 
> > > I still haven't seen this patch in Linus' tree. And you do need select
> > > SOUND and SND. Otherwise you still get build errors. I have tested this
> > > on my machine. So can someone please submit a proper patch to get this
> > > fixed.
> > 
> > Ugh.  Please don't 'select' to build an entire subsystem.
> 
> I won't in this case. I think I will cook up a patch to disable the entire
> mixer subsystem in thinkpad-acpi if CONFIG_SND is not available.  I don't
> like the depends on SND though.

That's also not so trivial unless you give any dependency in Kconfig.
Without a restriction, THINKPAD_ACPI=y and SND=m can be chosen.

It'd be also not nice if suddenly a certain functionality disappears
without warning (even if the subsystem is enabled but as a module).


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/