Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756457AbZLWRdp (ORCPT ); Wed, 23 Dec 2009 12:33:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754709AbZLWRdo (ORCPT ); Wed, 23 Dec 2009 12:33:44 -0500 Received: from one.firstfloor.org ([213.235.205.2]:51834 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754468AbZLWRdn (ORCPT ); Wed, 23 Dec 2009 12:33:43 -0500 Date: Wed, 23 Dec 2009 18:33:39 +0100 From: Andi Kleen To: Gregory Haskins Cc: Andi Kleen , Ingo Molnar , Anthony Liguori , Bartlomiej Zolnierkiewicz , Avi Kivity , kvm@vger.kernel.org, Andrew Morton , torvalds@linux-foundation.org, "linux-kernel@vger.kernel.org" , netdev@vger.kernel.org, "alacrityvm-devel@lists.sourceforge.net" Subject: Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33 Message-ID: <20091223173339.GL20539@basil.fritz.box> References: <4B1D4F29.8020309@gmail.com> <87637zdy9g.fsf@basil.nowhere.org> <4B30E654.40702@codemonkey.ws> <200912221701.56840.bzolnier@gmail.com> <4B30F214.80206@codemonkey.ws> <20091223065129.GA19600@elte.hu> <4B3248F9.5030504@gmail.com> <20091223171052.GI20539@basil.fritz.box> <4B3250BC.50203@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B3250BC.50203@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1442 Lines: 32 On Wed, Dec 23, 2009 at 12:17:48PM -0500, Gregory Haskins wrote: > On 12/23/09 12:10 PM, Andi Kleen wrote: > >> And its moot, anyway, as I have already retracted my one outstanding > >> pull request based on Linus' observation. So at this time, I am not > >> advocating _anything_ for upstream inclusion. And I am contemplating > >> _never_ doing so again. It's not worth _this_. > > > > That certainly sounds like the wrong reaction. Out of tree drivers > > are typically a pain to use. > > Well, to Linus' point, it shouldn't go in until a critical mass of users > have expressed desire to see it in tree, which seems reasonable to me. > For the admittedly small group that are using it today, modern tools > like the opensuse-build-service ease the deployment as a KMP, so that > can suffice for now. Its actually what most of the alacrityvm community > uses today anyway (as opposed to using a merged tree in the guest) It would be probably also good to have some more exhaustive data showing any performance improvements. Your numbers are very hard to compare to Chris' numbers and not as comprehensive (e.g. no latencies) -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/